Re: [3/5] WineD3D: Test and fix ddraw and d3d9 GetDC differences

[Paul Vriens]

On 09/05/2009 04:54 PM, Stefan Dösinger wrote:
> This patch uses a d3d9-side filter in favor of adding a 2nd set of
> getdc-capable format flags.

Hi Stefan,

These tests have failures on Vista+ boxes:

dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface 
failed(0x88760249), expected it to work
dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface 
failed(0x88760249), expected it to work
dsurface.c:3243: Test failed: GetDC on a D3DFMT_A4R4G4B4 surface 
failed(0x88760249), expected it to work
dsurface.c:3243: Test failed: GetDC on a D3DFMT_X4R4G4B4 surface 
failed(0x88760249), expected it to work

These are real ones with NVIDIA, ATI and Intel cards but also VMware 
boxes with the latest VMware driver "VMware SVGA 3D (Microsoft 
Corporation - WDDM)".

Should I change the test to introduce an alternative result for these 4 
formats?

[3/5] WineD3D: Test and fix ddraw and d3d9 GetDC differences

[Stefan Dösinger]

Am 10.12.2009 um 09:57 schrieb Paul Vriens:
> On 09/05/2009 04:54 PM, Stefan Dösinger wrote:
> > This patch uses a d3d9-side filter in favor of adding a 2nd set of
> > getdc-capable format flags.
>
> Hi Stefan,
>
> These tests have failures on Vista+ boxes:
>
> dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface failed(0x88760249), expected it to work
> dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface failed(0x88760249), expected it to work
> dsurface.c:3243: Test failed: GetDC on a D3DFMT_A4R4G4B4 surface failed(0x88760249), expected it to work
> dsurface.c:3243: Test failed: GetDC on a D3DFMT_X4R4G4B4 surface failed(0x88760249), expected it to work
>
> These are real ones with NVIDIA, ATI and Intel cards but also VMware boxes with the latest VMware driver "VMware SVGA 3D (Microsoft Corporation - WDDM)".
>
> Should I change the test to introduce an alternative result for these 4 formats?

Yes, this is what we have to do it seem. I am slightly surprised about the A4R4G4B4 failure, this is a quite common format. I wouldn't be surprised if some games fail because of that, but I don't know any suspicious ones to test with.

X8B8G8R8 is used rarely, so I guess if that fails its not an issue.