re: Anotated 'make test' log

[Dan Kegel]

What problem are you trying to solve?
I gather you're just plowing through the output of 'make test',
looking at each bit of noise, and trying to figure out a way
to improve the tests?

While that's a noble quest, and I'd like to
encourage people to improve the tests,
it might be more productive to do so
around areas of pain for users.

For instance, you could look at bugs in bugzilla
that have patches attached that aren't committed
yet because tests are needed, and write those
tests.
- Dan

Anotated 'make test' log

[Dan Kegel]

Max wrote:
> A little reassurance that I am not crazy and
> have the social skills needed to contribute to the community
> are what I need at the moment.

OK.  I'd suggest starting by looking at
http://bugs.winehq.org/show_bug.cgi?id=15435
"Wine logs too verbose, quieter fixme's needed"
and sending in a patch to make one of the overly-verbose
fixme's a bit quieter.

Also, check your mail system; I can't email to you directly,
it bounces.  And that's going to be a problem communicating
with other developers.
- Dan

Anotated 'make test' log

[Dan Kegel]

Max wrote:
> [Maybe we should modify FIXME itself to only print out once.]

That's worth discussing, but changing FIXME itself might be going a
bit too far during the current code freeze.
You could try adding a FIXME_ONCE macro, though, and use it to quiet
some particular message that really gets in the way of (i.e. slows down)
a real application.

(p.s. the mail bounces are really distracting; they look like this:
Delivery to the following recipient failed permanently:
    [e-mail]
Technical details of permanent failure:
Google tried to deliver your message, but it was rejected by the
recipient domain. We recommend contacting the other email provider for
further information about the cause of this error. The error that the
other server returned was: 550 550 5.7.1 ...
Relaying denied (state 14).)

Anotated 'make test' log

[James McKenzie]

Dan Kegel wrote:
> Max wrote:
> > [Maybe we should modify FIXME itself to only print out once.]
>
> That's worth discussing, but changing FIXME itself might be going a
> bit too far during the current code freeze.
> You could try adding a FIXME_ONCE macro, though, and use it to quiet
> some particular message that really gets in the way of (i.e. slows down)
> a real application.

Dan:

I've run into this with the fixme's in richedit many times.  I've seen 
screen 'studdering' and really don't know where the fixme belongs in my 
use/test of several programs over the last few days.  I will have time 
this weekend to look further into a couple of regressions (hopefully we 
will see one more cycle before Wine 1.2 is released) and possibly be 
able to fix or point out a fix to at least one of them.

James McKenzie

Anotated 'make test' log

[Max TenEyck Woodbury]

On 06/16/2010 04:48 PM, Dan Kegel wrote:
> Max wrote:
> > [Maybe we should modify FIXME itself to only print out once.]
>
> That's worth discussing, but changing FIXME itself might be going a
> bit too far during the current code freeze.
> You could try adding a FIXME_ONCE macro, though, and use it to quiet
> some particular message that really gets in the way of (i.e. slows down)
> a real application.

Something along the lines of?

#define FIXME_ONCE(...) \
do {    static volatile unsigned char   once = 0U; \
     if ( once == 0U ) { /* The race here is ignorable. */ \
         once = ^0U; \
         FIXME(__VA_ARGS__); \
     } \
} while(0)

Anotated 'make test' log

[Detlef Riekenberg]

Hi Max

Welcome to Wine.

Your Patch "[Add '_ONCE' variants of DPRINTF, FIXME, WARN.]"
( http://source.winehq.org/patches/data/63503 )
has a typo near the end:
  #define ERR_ONCE                   WINE_ERR_ONCEE

Anotated 'make test' log

[Max TenEyck Woodbury]

On 07/17/2010 10:27 AM, Detlef Riekenberg wrote:
> Hi Max
>
> Welcome to Wine.
>
> Your Patch "[Add '_ONCE' variants of DPRINTF, FIXME, WARN.]"
> ( http://source.winehq.org/patches/data/63503 )
> has a typo near the end:
>    #define ERR_ONCE                   WINE_ERR_ONCEE

Thank you! Fixed and resubmitted.