[PATCH 1/2] msi/tests: Also test full range of properties for MsiSummaryInfoSetPropertyW. (v2)

[Dmitry Timoshkov]

Signed-off-by: Dmitry Timoshkov 
---
 dlls/msi/tests/custom.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/dlls/msi/tests/custom.c b/dlls/msi/tests/custom.c
index f06aee0675..c9ec82fd93 100644
--- a/dlls/msi/tests/custom.c
+++ b/dlls/msi/tests/custom.c
@@ -510,12 +510,14 @@ static void test_db(MSIHANDLE hinst)

for (i = 0; i < 20; i++)
     {
+        WCHAR emptyW[1] = { 0 };
+
         r = MsiSummaryInfoSetPropertyA(suminfo, i, prop_type[i], 1252, &ft, "");
         ok(hinst, r == ERROR_FUNCTION_FAILED, "%u: got %u\n", i, r);
-    }

-    r = MsiSummaryInfoSetPropertyW(suminfo, PID_CODEPAGE, VT_I2, 1252, &ft, NULL);
-    ok(hinst, r == ERROR_FUNCTION_FAILED, "got %u\n", r);
+        r = MsiSummaryInfoSetPropertyW(suminfo, i, prop_type[i], 1252, &ft, emptyW);
+        ok(hinst, r == ERROR_FUNCTION_FAILED, "%u: got %u\n", i, r);
+    }

r = MsiCloseHandle(suminfo);
     ok(hinst, !r, "got %u\n", r);

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=42233

Your paranoid android.

=== w7u (32 bit Windows report) ===

msi:
action: Timeout

=== w7u (32 bit Windows report) ===

msi:
install: Timeout

=== w7u (32 bit Windows report) ===

msi:
msi: Timeout

=== w1064 (32 bit Windows report) ===

=== w1064 (task log) ===

Task errors:
TestBot process got stuck or died unexpectedly
The previous 1 run(s) terminated abnormally

[Hans Leidekker]

Signed-off-by: Hans Leidekker