Re: comctl32/listview: use the infile ImageListRelease

[Nikolay Sivov]

Hi, Andre.

Could you please wait with that? I have some similar patches already sent...

On 11/16/09, André Hentschel  wrote:
> Otherwise Apps crash on exit(e.g. uninstaller)
>
> dlls/comctl32/imagelist.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c
> index 82d2664..44084fd 100644
> --- a/dlls/comctl32/imagelist.c
> +++ b/dlls/comctl32/imagelist.c
> @@ -81,6 +81,7 @@ static INTERNALDRAG InternalDrag = { 0, 0, 0, 0, 0, 0,
> FALSE, 0 };
>
> static HBITMAP ImageList_CreateImage(HDC hdc, HIMAGELIST himl, UINT count,
> UINT width);
>  static HRESULT ImageListImpl_CreateInstance(const IUnknown *pUnkOuter,
> REFIID iid, void** ppv);
> +static ULONG WINAPI ImageListImpl_Release(IImageList *iface);
>
> static inline BOOL is_valid(HIMAGELIST himl)
>  {
> @@ -716,7 +717,7 @@ ImageList_Destroy (HIMAGELIST himl)
>          DeleteObject (himl->hbrBlend50);
>  /* Free the IImageList instance */
> - IImageList_Release((IImageList *) himl);
> - ImageListImpl_Release((IImageList *) himl);
> return TRUE;
>
> }
>
> --
>
> Best Regards, André Hentschel

comctl32/listview: use the infile ImageListRelease

[André Hentschel]

Nikolay Sivov schrieb:
> Hi, Andre.
>
> Could you please wait with that? I have some similar patches already sent...
>
> On 11/16/09, André Hentschel  wrote:
> > Otherwise Apps crash on exit(e.g. uninstaller)
> >
> > dlls/comctl32/imagelist.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c
> > index 82d2664..44084fd 100644
> > --- a/dlls/comctl32/imagelist.c
> > +++ b/dlls/comctl32/imagelist.c
> > @@ -81,6 +81,7 @@ static INTERNALDRAG InternalDrag = { 0, 0, 0, 0, 0, 0,
> > FALSE, 0 };
> >
> > static HBITMAP ImageList_CreateImage(HDC hdc, HIMAGELIST himl, UINT count,
> > UINT width);
> >  static HRESULT ImageListImpl_CreateInstance(const IUnknown *pUnkOuter,
> > REFIID iid, void** ppv);
> > +static ULONG WINAPI ImageListImpl_Release(IImageList *iface);
> >
> > static inline BOOL is_valid(HIMAGELIST himl)
> >  {
> > @@ -716,7 +717,7 @@ ImageList_Destroy (HIMAGELIST himl)
> >          DeleteObject (himl->hbrBlend50);
> >  /* Free the IImageList instance */
> > - IImageList_Release((IImageList *) himl);
> > - ImageListImpl_Release((IImageList *) himl);
> > return TRUE;
> >
> > }
> >
> > --
> >
> > Best Regards, André Hentschel

ok, of course!