On Sat, 2005-03-05 at 06:42, jchevrier@nexicom.net wrote:
As discussed on wine-devel there are a handful of calls in the SystemParametersInfo tests that don't check for returned errors and continue on with testing a given parameter. This patch ensures that all initial calls to SystemParametersInfoA in each parameter test have their returned errors checked. To ease adding more error cases and reduce code duplication I have consolidated error message handling into a single function.
Changelog:
- Consolidate error message handling
- Add error checking to all initial SystemParametersInfoA calls in each
parameter test to make sure that if a given parameter isn't supported or has failed in some other way that we return and don't continue on with the test
- Remove a couple of TABS and align registry keys/values at the top of the
file
Hi Justin,
could you have a look at the patch I send in for *MOUSEHOVER* stuff. Apparently Win98SE returns 0 without setting last error for the *MOUSEHOVER* ones. Could you incorporate this into your patch?
Mine is a bit 'overcomplete' as ERROR_CALL_NOT_IMPLEMENTED will probably never be returned (only for SystemParametersInfoA itself).
Shouldn't we also always do a SetLastError(0xdeadbeef) before every call to SystemParametersInfoA?
Cheers,
Paul.
-
Paul Vriens