Signed-off-by: Sven Baars sven.wine@gmail.com --- dlls/devenum/tests/devenum.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/dlls/devenum/tests/devenum.c b/dlls/devenum/tests/devenum.c index 10ca27a614..ec311ceab4 100644 --- a/dlls/devenum/tests/devenum.c +++ b/dlls/devenum/tests/devenum.c @@ -95,6 +95,7 @@ static void test_devenum(IBindCtx *bind_ctx) if (winetest_debug > 1) trace("%s %s:\n", wine_dbgstr_guid(&cat_guid), wine_dbgstr_w(V_BSTR(&var)));
+ VariantClear(&var); IPropertyBag_Release(prop_bag); IMoniker_Release(moniker);
Signed-off-by: Sven Baars sven.wine@gmail.com --- dlls/devenum/mediacatenum.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/devenum/mediacatenum.c b/dlls/devenum/mediacatenum.c index 5fa2f008dc..d8541edb3c 100644 --- a/dlls/devenum/mediacatenum.c +++ b/dlls/devenum/mediacatenum.c @@ -887,6 +887,8 @@ static HRESULT WINAPI DEVENUM_IEnumMoniker_Next(IEnumMoniker *iface, ULONG celt,
StringFromGUID2(&clsid, buffer, CHARS_IN_GUID); StringFromGUID2(&This->class, buffer + CHARS_IN_GUID - 1, CHARS_IN_GUID); + + CoTaskMemFree(name); } /* try DirectShow filters */ else if (!(res = RegEnumKeyW(This->sw_key, This->sw_index, buffer, ARRAY_SIZE(buffer))))
On 12/17/2018 02:27 PM, Sven Baars wrote:
Signed-off-by: Sven Baars sven.wine@gmail.com
dlls/devenum/mediacatenum.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/devenum/mediacatenum.c b/dlls/devenum/mediacatenum.c index 5fa2f008dc..d8541edb3c 100644 --- a/dlls/devenum/mediacatenum.c +++ b/dlls/devenum/mediacatenum.c @@ -887,6 +887,8 @@ static HRESULT WINAPI DEVENUM_IEnumMoniker_Next(IEnumMoniker *iface, ULONG celt,
StringFromGUID2(&clsid, buffer, CHARS_IN_GUID); StringFromGUID2(&This->class, buffer + CHARS_IN_GUID - 1, CHARS_IN_GUID);
CoTaskMemFree(name); } /* try DirectShow filters */ else if (!(res = RegEnumKeyW(This->sw_key, This->sw_index, buffer, ARRAY_SIZE(buffer))))
It looks like msdmo shouldn't actually require this parameter; so I think it'd be better to fix msdmo and then just pass NULL here.
On 17-12-18 21:48, Zebediah Figura wrote:
On 12/17/2018 02:27 PM, Sven Baars wrote:
Signed-off-by: Sven Baars sven.wine@gmail.com
dlls/devenum/mediacatenum.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/devenum/mediacatenum.c b/dlls/devenum/mediacatenum.c index 5fa2f008dc..d8541edb3c 100644 --- a/dlls/devenum/mediacatenum.c +++ b/dlls/devenum/mediacatenum.c @@ -887,6 +887,8 @@ static HRESULT WINAPI DEVENUM_IEnumMoniker_Next(IEnumMoniker *iface, ULONG celt, StringFromGUID2(&clsid, buffer, CHARS_IN_GUID); StringFromGUID2(&This->class, buffer + CHARS_IN_GUID - 1, CHARS_IN_GUID);
+ CoTaskMemFree(name); } /* try DirectShow filters */ else if (!(res = RegEnumKeyW(This->sw_key, This->sw_index, buffer, ARRAY_SIZE(buffer))))
It looks like msdmo shouldn't actually require this parameter; so I think it'd be better to fix msdmo and then just pass NULL here.
Ah, I see. I assumed it was intended that it returns E_POINTER, but tests indicate that it shouldn't do that. I guess that would have to wait until after the freeze, right?
On 12/17/2018 02:59 PM, Sven Baars wrote:
On 17-12-18 21:48, Zebediah Figura wrote:
On 12/17/2018 02:27 PM, Sven Baars wrote:
Signed-off-by: Sven Baars sven.wine@gmail.com
dlls/devenum/mediacatenum.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/devenum/mediacatenum.c b/dlls/devenum/mediacatenum.c index 5fa2f008dc..d8541edb3c 100644 --- a/dlls/devenum/mediacatenum.c +++ b/dlls/devenum/mediacatenum.c @@ -887,6 +887,8 @@ static HRESULT WINAPI DEVENUM_IEnumMoniker_Next(IEnumMoniker *iface, ULONG celt, StringFromGUID2(&clsid, buffer, CHARS_IN_GUID); StringFromGUID2(&This->class, buffer + CHARS_IN_GUID - 1, CHARS_IN_GUID);
+ CoTaskMemFree(name); } /* try DirectShow filters */ else if (!(res = RegEnumKeyW(This->sw_key, This->sw_index, buffer, ARRAY_SIZE(buffer))))
It looks like msdmo shouldn't actually require this parameter; so I think it'd be better to fix msdmo and then just pass NULL here.
Ah, I see. I assumed it was intended that it returns E_POINTER, but tests indicate that it shouldn't do that. I guess that would have to wait until after the freeze, right?
I don't see it as a potentially breaking change, but I guess it's up to Alexandre's judgement. A leak in devenum is hardly urgent anyway ;-)
Signed-off-by: Sven Baars sven.wine@gmail.com --- dlls/dsound/dsound_main.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/dlls/dsound/dsound_main.c b/dlls/dsound/dsound_main.c index 8dd86e40ed..4e752be6ba 100644 --- a/dlls/dsound/dsound_main.c +++ b/dlls/dsound/dsound_main.c @@ -480,6 +480,7 @@ HRESULT enumerate_mmdevices(EDataFlow flow, GUID *guids, }
if(count == 0){ + IMMDeviceCollection_Release(coll); release_mmdevenum(devenum, init_hr); return DS_OK; }
Signed-off-by: Andrew Eikum aeikum@codeweavers.com
On Mon, Dec 17, 2018 at 09:28:00PM +0100, Sven Baars wrote:
Signed-off-by: Sven Baars sven.wine@gmail.com
dlls/dsound/dsound_main.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/dlls/dsound/dsound_main.c b/dlls/dsound/dsound_main.c index 8dd86e40ed..4e752be6ba 100644 --- a/dlls/dsound/dsound_main.c +++ b/dlls/dsound/dsound_main.c @@ -480,6 +480,7 @@ HRESULT enumerate_mmdevices(EDataFlow flow, GUID *guids, }
if(count == 0){
IMMDeviceCollection_Release(coll); release_mmdevenum(devenum, init_hr); return DS_OK;-- 2.17.1
-
Andrew Eikum -
Sven Baars -
Zebediah Figura