Re: mshtml: Improve status messages sent to IOleInPlaceFrame

[Jacek Caban]

Hi Alexander,

On 7/26/10 11:36 AM, Alexander Nicolaysen Sørnes wrote:
> In preparation for adding a status bar to Wine's IE

-            static const WCHAR wszDone[] = {'D','o','n','e',0};
+            static WCHAR wszDone[40] = { 0 };
+
+            if(!wszDone[0])
+                LoadStringW(hInst, IDS_DONE, wszDone, sizeof(wszDone)/sizeof(wszDone[0]));
              IOleInPlaceFrame_SetStatusText(doc_obj->frame, wszDone);

SetStatusText call really deserves a helper function that would take care 
of loading the string resources instead of duplicating the code.

@@ -44,6 +45,7 @@ typedef struct {
      task_t header;
      HTMLDocumentObj *doc;
      BOOL set_download;
+    BSTR url;
  } download_proc_task_t;

You don't need this, URL is stored in HTMLWindow object at this point.

Jacek

mshtml: Improve status messages sent to IOleInPlaceFrame

[Alexander Nicolaysen Sørnes]

Mandag 26. juli 2010 15.59.55 skrev Jacek Caban :
> Hi Alexander,
>
> On 7/26/10 11:36 AM, Alexander Nicolaysen Sørnes wrote:
> > In preparation for adding a status bar to Wine's IE
> -
>        static const WCHAR wszDone[] = {'D','o','n','e',0};
> -
>        static WCHAR wszDone[40] = { 0 };
> -
> -
>        if(!wszDone[0])
> -
>            LoadStringW(hInst, IDS_DONE, wszDone,
>
> sizeof(wszDone)/sizeof(wszDone[0]));
>  IOleInPlaceFrame_SetStatusText(doc_obj->frame, wszDone);
>
> SetStatusText call really deserves a helper function that would take care
> of loading the string resources instead of duplicating the code.
>
> @@ -44,6 +45,7 @@ typedef struct {
>       task_t header;
>       HTMLDocumentObj *doc;
>       BOOL set_download;
> - BSTR url;
> } download_proc_task_t;
>
> You don't need this, URL is stored in HTMLWindow object at this point.
>
> Jacek

Thanks! I'll make a new version

Alexander N. Sørnes