Fwd: shell32: fix SHFileOperation copying to an empty file list

[Vincent Povirk]

Grr, forgot to copy list.

---------- Forwarded message ----------
From: Vincent Povirk 
Date: Sat, May 31, 2008 at 9:46 PM
Subject: Re: shell32: fix SHFileOperation copying to an empty file list
To: James Hawkins

On Sat, May 31, 2008 at 9:42 PM, James Hawkins  wrote:
> I'm not either.  There's a very simple way to implement this.  Also,
> you need to add tests for the FO_MOVE action as well.

Do tell, sir.

None of the other operations actually succeed when the destination is
an empty list (except delete of course). I can add tests for them to
ensure they don't crash, but it seems unnecessary.
> @@ -131,6 +132,7 @@ static void clean_after_shfo_tests(void)
>     DeleteFileA("test3.txt");
>     DeleteFileA("test_5.txt");
>     DeleteFileA("one.txt");
> - DeleteFileA("filename.tex");
> DeleteFileA("test4.txt\test1.txt");
> DeleteFileA("test4.txt\test2.txt");
> DeleteFileA("test4.txt\test3.txt");
>
> typo, and why didn't you stick with the convention used for all the
> other test files (.txt, not .text)?

This was intentional. It was to show that extensions are trimmed to
three characters in this case.

--
Vincent Povirk

shell32: fix SHFileOperation copying to an empty file list

[James Hawkins]

On Sat, May 31, 2008 at 8:47 PM, Vincent Povirk
 wrote:
> Grr, forgot to copy list.
>
> ---------- Forwarded message ----------
> From: Vincent Povirk 
> Date: Sat, May 31, 2008 at 9:46 PM
> Subject: Re: shell32: fix SHFileOperation copying to an empty file list
> To: James Hawkins
>
> On Sat, May 31, 2008 at 9:42 PM, James Hawkins  wrote:
> > I'm not either.  There's a very simple way to implement this.  Also,
> > you need to add tests for the FO_MOVE action as well.
>
> Do tell, sir.
>
> None of the other operations actually succeed when the destination is
> an empty list (except delete of course). I can add tests for them to
> ensure they don't crash, but it seems unnecessary.

I only referred to FO_MOVE, and if the two operations that use the
'to' parameter behave differently, then you certainly need a test to
show this.  It determines how you implement the fix for FO_COPY.
> > @@ -131,6 +132,7 @@ static void clean_after_shfo_tests(void)
> >     DeleteFileA("test3.txt");
> >     DeleteFileA("test_5.txt");
> >     DeleteFileA("one.txt");
> > - DeleteFileA("filename.tex");
> > DeleteFileA("test4.txt\test1.txt");
> > DeleteFileA("test4.txt\test2.txt");
> > DeleteFileA("test4.txt\test3.txt");
> >
> > typo, and why didn't you stick with the convention used for all the
> > other test files (.txt, not .text)?
>
> This was intentional. It was to show that extensions are trimmed to
> three characters in this case.

What does that have to do with this fix?  You don't talk about it in
your email, changelog, or the code.

shell32: fix SHFileOperation copying to an empty file list

[Vincent Povirk]

OK, I'll add the test for FO_MOVE.

On Sat, May 31, 2008 at 9:52 PM, James Hawkins  wrote:
> What does that have to do with this fix?  You don't talk about it in
> your email, changelog, or the code.

It's part of truncating to 8.3 format. The extension can't be longer
than 3 characters.

shell32: fix SHFileOperation copying to an empty file list

[James Hawkins]

On Sat, May 31, 2008 at 8:56 PM, Vincent Povirk
 wrote:
> OK, I'll add the test for FO_MOVE.
>
> On Sat, May 31, 2008 at 9:52 PM, James Hawkins  wrote:
> > What does that have to do with this fix?  You don't talk about it in
> > your email, changelog, or the code.
>
> It's part of truncating to 8.3 format. The extension can't be longer
> than 3 characters.

That doesn't answer the question.