Re: winmm/wineoss: Cast-qual warning fix

[Marcus Meissner]

On Thu, Nov 23, 2006 at 08:29:00PM +0000, Andrew Talbot wrote:
> Changelog:
>     winmm/wineoss: Cast-qual warning fix.
>
> diff -urN a/dlls/winmm/wineoss/dscapture.c b/dlls/winmm/wineoss/dscapture.c
> --- a/dlls/winmm/wineoss/dscapture.c	2006-11-13 17:34:40.000000000 +0000
> +++ b/dlls/winmm/wineoss/dscapture.c	2006-11-23 20:15:22.000000000 +0000
> @@ -853,7 +853,7 @@
>  {
>      int i;
>      for (i = 0; i < length; i++)
> -
>    ((char *)dst)[i] = ((char *)src)[i];
> -
>    ((char *)dst)[i] = ((const char *)src)[i];
> return dst;
>
> }

I really wonder why we do have our own memcpy() here and why there is a 
strange /* FIXME: using memcpy can cause strange crashes so use this fake one */
comment above it.

Ciao, Marcus

winmm/wineoss: Cast-qual warning fix

[Eric Pouech]

> I really wonder why we do have our own memcpy() here and why there is a 
> strange /* FIXME: using memcpy can cause strange crashes so use this fake one */
> comment above it.

may be optimisations in memcpy using dword* reads and writes may cause 
issues in buffers mapped by the sound driver (depending on how it's done)