Re: [v3] winex11: Use XIAllDevices to select for XI_RawMotion

[Carlos Garnacho]

Hi all,

Got this message from Marvin about "formatting", but I'm not sure what
could have triggered this. Getting picky I see the parens at the
update_relative_valuators function aren't alright given surrounding
code style, but I see nothing specifically against
https://wiki.winehq.org/Submitting_Patches#Code_guidelines or
https://source.winehq.org/patches/#legend

Is there anything actually wrong? I'll be happy to send an updated patch.

Cheers,
  Carlos

On Mon, Dec 12, 2016 at 11:15 PM, Marvin  wrote:
> Thank you for your contribution to Wine!
>
> This is an automated notification to let you know that your patch has
> been reviewed and its status set to "Formatting".
>
> This means that there are some formatting issues with your
> patch. Either the author's full name, email address, or Signed-off-by
> headers are missing, indentation is messed up (usually from editing
> with a non-standard tab size), or there are gratuitous formatting
> changes to the code. You need to resend a fixed patch.
>
> If you do not understand the reason for this status, disagree with our
> assessment, or are simply not sure how to proceed next, please ask for
> clarification by replying to this email.

[v3] winex11: Use XIAllDevices to select for XI_RawMotion

[Alexandre Julliard]

Carlos Garnacho  writes:
> Hi all,
>
> Got this message from Marvin about "formatting", but I'm not sure what
> could have triggered this. Getting picky I see the parens at the
> update_relative_valuators function aren't alright given surrounding
> code style, but I see nothing specifically against
> https://wiki.winehq.org/Submitting_Patches#Code_guidelines or
> https://source.winehq.org/patches/#legend
>
> Is there anything actually wrong? I'll be happy to send an updated patch.

Sorry, the "formatting" status was my mistake. It was meant to be marked
"deferred", as in being too large to go in during code freeze.

[v3] winex11: Use XIAllDevices to select for XI_RawMotion

[Carlos Garnacho]

Hi Alexandre,

On Thu, Dec 15, 2016 at 8:26 AM, Alexandre Julliard  wrote:
> Carlos Garnacho  writes:
> > Hi all,
> >
> > Got this message from Marvin about "formatting", but I'm not sure what
> > could have triggered this. Getting picky I see the parens at the
> > update_relative_valuators function aren't alright given surrounding
> > code style, but I see nothing specifically against
> > https://wiki.winehq.org/Submitting_Patches#Code_guidelines or
> > https://source.winehq.org/patches/#legend
> >
> > Is there anything actually wrong? I'll be happy to send an updated patch.
>
> Sorry, the "formatting" status was my mistake. It was meant to be marked
> "deferred", as in being too large to go in during code freeze.

Oh, sure, that's perfectly understandable. Congrats for the ongoing 2.0 release!

Cheers,
  Carlos