-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-16 um 11:21 schrieb Jonathan Vollebregt:
+static int reg_add( const WCHAR *key_name, const WCHAR *value_name, const BOOL value_empty,
const WCHAR *type, const WCHAR separator, const WCHAR *data,const BOOL force)
Forgive me if I have asked this already: Do we have any precedent for this function declaration style in Wine?
Patches 1-6 look good to me. I will tell Alexandre on IRC.
Not that I'm aware of, it just seemed more readable to me. Want me to change it?
On 02/16/2015 12:28 PM, Stefan Dösinger wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-16 um 11:21 schrieb Jonathan Vollebregt:
+static int reg_add( const WCHAR *key_name, const WCHAR *value_name, const BOOL value_empty,
const WCHAR *type, const WCHAR separator, const WCHAR *data,const BOOL force)Forgive me if I have asked this already: Do we have any precedent for this function declaration style in Wine?
Patches 1-6 look good to me. I will tell Alexandre on IRC. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQIcBAEBAgAGBQJU4dRLAAoJEN0/YqbEcdMwlrIP/0HfUXV9QWb2ZiR0VOq8fIjn qZ75XFoN2yMxdHloVVHFqQe0sRRG9udVuGUq33b5eA9JCGUdCEV4FV1R2KrKUNaP 2nmwFCh67qqQBH1AnRZLVcQgzQGbvkVgzT8w46vtIlvL1EqAaT51lCB+Q1kWEj34 Y9W1SR0T4Yesxtg/rKDsUJZC3WoMq5q/tsPhs//K/1KTAlllVFLnTtu955kPr1IB EwfB6nfsdtLi7D/BTjbTmuYBblCF9EnvRXjbul2AwN/he6UvYcVR3+rmRMk8oGQ2 zlquslix7Ch2VY1gtguy67ZDTWlSwXXE4p8/9weavSYomHR7Sqq/3DNmTAOyHYZ2 m/NUZVo/oBlpywPCuhFk36uxrUku3FprFLRGAwvo0we1EnF8tw9YRLyl9crz6xVA vR6vgf/CSiqmDdS2OCnGQ0/H6aKU/WhsXF839v2ty5jCI95yQoHthybVTd9EZfYj nZpXe1dIMmJDb2eEoPzTlvm8/Na+0zQjvsk695t4wnP1xe4vicE8gl8SWW8KNOrP 23Hyhg42BwE3H2m5F8KqhdeE2XMbgD3GoBV+EMKaEVHE3FsLmHhAOMzgJQ/UEukH CX9oHWcbUTmtcu+RAl33UaSSSl4p0wz4rZa+NzlpgqEzvUO5izfMeHPV1udV9tP+ e/wAP5+YAUt5T8+LoRI8 =KrQx -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-16 um 12:34 schrieb Jonathan Vollebregt:
Not that I'm aware of, it just seemed more readable to me. Want me to change it?
Yes please. We already have enough style mess in Wine :-( .
I recommend to wait for Alexandre's response to patches 1-6 before you resubmit 7 and 8.
These (1/2 reg_add, 2/2 reg_delete) won't pass testbot but besides the whitespace they're the same as the 7/8 patches that already did.
On 02/16/2015 01:27 PM, Stefan Dösinger wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-16 um 12:34 schrieb Jonathan Vollebregt:
Not that I'm aware of, it just seemed more readable to me. Want me to change it?
Yes please. We already have enough style mess in Wine :-( .
I recommend to wait for Alexandre's response to patches 1-6 before you resubmit 7 and 8. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQIcBAEBAgAGBQJU4eIlAAoJEN0/YqbEcdMwtjkP/3/v6kdAuVMd4mu9ovroKvOr y/P7X+QsD28nWbJ4rJ/CfpHiabB5ynw50oM2biROsIUmH3NE3kz5ffJLE8m6q9b4 WJcLRSlpGlFXGL2xXdE/0MdR6BqOsh4W1d1sKb634p8FGuk2E8Z2Jv84A3M7ivDt mtkPy7a3vDfc1Y39zH5oOn4NGMWRaps8okKQD2m8AdXk0RYRck3YeIAcJQdnkuCT 7fWMaXx0awh3fnpXIW73SaoRipqq78KUqGpnP4ZoF0xRPH/W6w2Qij9g0wUgF6Az xjyU4BSomDEvfcW3zLiUF037fY9+PIXihoI4kQgnUlOBjw3C/ss1ZFrK1ggfYIz8 mtgDptgutE2NUi69GiUxkSH0YghWcH+etePc0GS/C+pCyS8CIl25rQVVbKvbblqC 9QdhivC4ptbuCpM7Aj6suOQU57jovHa/QEav3KGgd/9S25JOC6EmHZE3zl6/GwZm 2+8o/S25YSJlNgMEFRRjg75LvEUlyjfZt6CIzID7uY00MqauPF0yVus6VEhSrOfv Z4ynGCc0C/MDwFU5coXMZQZ1hZaHeKQBZiM1kzbJZBbG3ocmf0chmasyLzZw1wEf YrmmGQMJU4IB+wINjqgSPCsNSg/nxSYzrN6+2T2gN10YXU+FqRacxc09JUs/SjMo cTdsI2FZd4x4EVMH+wKe =RCR0 -----END PGP SIGNATURE-----
-
Jonathan Vollebregt -
Stefan Dösinger