I can't do a deep review, but I did see that you have some commented out code, and IIRC AJ doesn't like that. Better to remove it than comment it out.
BTW, besides the three apps mentioned in http://bugs.winehq.org/show_bug.cgi?id=6254, what apps depend on this? - Dan
Dan Kegel wrote:
I can't do a deep review, but I did see that you have some commented out code, and IIRC AJ doesn't like that. Better to remove it than comment it out.
Point taken. I still would like to know where to break this up. I know that the removal of the todo_wine should be separate from the main patch body.
BTW, besides the three apps mentioned in http://bugs.winehq.org/show_bug.cgi?id=6254, what apps depend on this?
I don't know. I had several apps that did not run under wine-1.1.6 but do under wine-1.1.7. I'm looking at this as well as the mismatched size of the Print Preview for Wordpad/Wordpad.exe.
James McKenzie