Re: msvcrt:locale Properly fix setlocale()

[Alexandre Julliard]

Alexandre Goujon  writes:
> @@ -431,7 +431,7 @@ static void test_setlocale(void)
>      ret = setlocale(LC_ALL, "non");
>      ok(ret != NULL || broken (ret == NULL), "ret == NULL\n");
>      if(ret)
> -
>    todo_wine ok((!strcmp( ret, "Norwegian-Nynorsk_Norway.1252"))
> -
>    ok((!strcmp( ret, "Norwegian-Nynorsk_Norway.1252"))
>    || broken(!strcmp(ret, "Norwegian (Bokmål)_Norway.1252"))
>    || broken(!strcmp(ret, "Norwegian_Norway.1252"))
>    || broken(!strcmp(ret, "Norwegian (Nynorsk)_Norway.1252")), "ret = %s\n", ret);
>
> @@ -453,7 +453,7 @@ static void test_setlocale(void)
>      ret = setlocale(LC_ALL, "norwegian-nynorsk");
>      ok(ret != NULL || broken (ret == NULL), "ret == NULL\n");
>      if(ret)
> -
>    todo_wine ok(!strcmp(ret, "Norwegian-Nynorsk_Norway.1252")
> -
>    ok(!strcmp(ret, "Norwegian-Nynorsk_Norway.1252")
>    || broken(!strcmp(ret, "Norwegian_Norway.1252"))
>    || broken(!strcmp(ret, "Norwegian (Nynorsk)_Norway.1252"))
>    || broken(!strcmp(ret, "Norwegian (Bokmal)_Norway.1252"))

I don't think it makes sense to declare minor spelling differences as
broken, or to change the kernel resources for this.

msvcrt:locale Properly fix setlocale()

[GOUJON Alexandre]

On 08/27/2010 03:22 PM, Alexandre Julliard wrote:
> I don't think it makes sense to declare minor spelling differences as
> broken, or to change the kernel resources for this

I did not write these broken. I just removed the todo_wine and fix the nls.
I think they have been added to match what wine setlocale was returning.
Should I resend my patch removing all of these broken() ?

msvcrt:locale Properly fix setlocale()

[Alexandre Julliard]

GOUJON Alexandre  writes:
> On 08/27/2010 03:22 PM, Alexandre Julliard wrote:
> > I don't think it makes sense to declare minor spelling differences as
> > broken, or to change the kernel resources for this
>
> I did not write these broken. I just removed the todo_wine and fix the nls.
> I think they have been added to match what wine setlocale was returning.
> Should I resend my patch removing all of these broken() ?

Not all of them, but those that don't make sense, yes. For instance
"Norwegian-Nynorsk" and "Norwegian (Nynorsk)" are both OK since they
both appear on Windows, there's no reason to declare one broken.