On Fri, Apr 1, 2011 at 23:14, Vincent Pelletier plr.vincent@gmail.com wrote:
Fixes bug 22635.
dlls/kernel32/tests/file.c | 119 ++++++++++++++++++++++++++++++++++++++++++++ dlls/ntdll/path.c | 8 +++- 2 files changed, 126 insertions(+), 1 deletions(-)
Your patch changelog is misleading. You're not just adding tests, but fixing the bug. Either send the tests as a single patch and the fix separately(and removing any todo_wine()'s that it fixes) or change the summary to describe the fix.
Le samedi 02 avril 2011 00:18:16, Austin English a écrit :
Your patch changelog is misleading. You're not just adding tests, but fixing the bug. Either send the tests as a single patch and the fix separately(and removing any todo_wine()'s that it fixes) or change the summary to describe the fix.
Woops, indeed. This, and I should rebase to remote before sending.