[PATCH 1/4] user32: Remove an unnecessary static.

[Huw Davies]

Signed-off-by: Huw Davies 
---
 dlls/user32/user_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/user32/user_main.c b/dlls/user32/user_main.c
index 31a6168108c..f050e5d92e5 100644
--- a/dlls/user32/user_main.c
+++ b/dlls/user32/user_main.c
@@ -173,7 +173,7 @@ static const WCHAR *get_default_desktop(void)
     static const WCHAR app_defaultsW[] = {'S','o','f','t','w','a','r','e','\',
                                           'W','i','n','e','\',
                                           'A','p','p','D','e','f','a','u','l','t','s',0};
-    static WCHAR buffer[MAX_PATH + ARRAY_SIZE(explorerW)];
+    WCHAR buffer[MAX_PATH + ARRAY_SIZE(explorerW)];
     WCHAR *p, *appname = buffer;
     const WCHAR *ret = defaultW;
     DWORD len;

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=74077

Your paranoid android.

=== debiant (64 bit WoW report) ===

user32:
win.c:10147: Test failed: GetActiveWindow() = 00000000
win.c:10147: Test failed: GetFocus() = 00000000
win.c:10149: Test failed: Expected foreground window 000D0120, got 00E300D4
win.c:10152: Test failed: Received WM_ACTIVATEAPP(0), did not expect it.
win.c:10159: Test failed: Expected foreground window 000D0120, got 00000000
win.c:10161: Test failed: GetActiveWindow() = 00000000
win.c:10161: Test failed: GetFocus() = 00000000
win.c:10169: Test failed: Received WM_ACTIVATEAPP(1), did not expect it.

[Huw Davies]

On Wed, Jun 24, 2020 at 10:19:18AM +0100, Huw Davies wrote:
> Signed-off-by: Huw Davies
>
> dlls/user32/user_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/user32/user_main.c b/dlls/user32/user_main.c
> index 31a6168108c..f050e5d92e5 100644
> --- a/dlls/user32/user_main.c
> +++ b/dlls/user32/user_main.c
> @@ -173,7 +173,7 @@ static const WCHAR *get_default_desktop(void)
>      static const WCHAR app_defaultsW[] = {'S','o','f','t','w','a','r','e','\',
>                                            'W','i','n','e','\',
>                                            'A','p','p','D','e','f','a','u','l','t','s',0};
> - static WCHAR buffer[MAX_PATH + ARRAY_SIZE(explorerW)];
> - WCHAR buffer[MAX_PATH + ARRAY_SIZE(explorerW)];
> WCHAR *p, *appname = buffer;
> const WCHAR *ret = defaultW;
> DWORD len;

Actually ignore this.  We may return a ptr to this buffer...

Huw.