Possible Fix?

[Anthony Tuininga]

I installed Dynomite for Windows (from PopCap) into a Wine-only
installation and noticed that as I moved the window, the images and
sprites were offset by the corresponding amount. I added a return
statement into the following file (updated from CVS as of today) and the
problem went away almost completely. On occasion repainting still can be
problematic but overall things work much better.

windows/winpos.c, in function WINPOS_GetWinOffset() I simply returned
immediately following the line which sets the X and Y offsets to 0. Now
I suspect that the rest of the code is rather necessary in some
instances but in this particular case it is getting in the road. Any
comments?

Anthony

Bug in WINPOS_GetWinOffset? (was Possible Fix?)

[Joshua Thielen]

Hello everybody,

I don't know if this is related to the bug Anthony
encountered, but why does WINPOS_GetWinOffset() use a
goto when it adds the offset of a parent window from
another process? Shouldn't the server request
'get_window_parents' be used to retrieve all of the
parent windows from other processes? Or can there only
be one parent from another process?

Josh

__________________________________________________
Do You Yahoo!?
Yahoo! Autos - Get free new car price quotes
http://autos.yahoo.com

Bug in WINPOS_GetWinOffset? (was Possible Fix?)

[Tony Lambregts]

Joshua Thielen wrote:
> Hello everybody,
>
> I don't know if this is related to the bug Anthony
> encountered, but why does WINPOS_GetWinOffset() use a
> goto when it adds the offset of a parent window from
> another process? Shouldn't the server request
> 'get_window_parents' be used to retrieve all of the
> parent windows from other processes? Or can there only
> be one parent from another process?
>
> Josh
>
> Do You Yahoo!?
> Yahoo! Autos - Get free new car price quotes
> http://autos.yahoo.com

Looks like we have the makings of a good bug report here. Could one of 
you start a bug report in bugzilla. (maybe not so) ugly hack included

Tony Lambregts

Bug in WINPOS_GetWinOffset? (was Possible Fix?)

[Anthony Tuininga]

Done. Bug #889.

On Wed, 2002-07-17 at 20:14, Tony Lambregts wrote:
> Joshua Thielen wrote:
> > Hello everybody,
> >
> > I don't know if this is related to the bug Anthony
> > encountered, but why does WINPOS_GetWinOffset() use a
> > goto when it adds the offset of a parent window from
> > another process? Shouldn't the server request
> > 'get_window_parents' be used to retrieve all of the
> > parent windows from other processes? Or can there only
> > be one parent from another process?
> >
> > Josh
> >
> > Do You Yahoo!?
> > Yahoo! Autos - Get free new car price quotes
> > http://autos.yahoo.com
>
> Looks like we have the makings of a good bug report here. Could one of 
> you start a bug report in bugzilla. (maybe not so) ugly hack included
>
> Tony Lambregts

Bug in WINPOS_GetWinOffset? (was Possible Fix?)

[Alexandre Julliard]

Joshua Thielen  writes:
> I don't know if this is related to the bug Anthony
> encountered, but why does WINPOS_GetWinOffset() use a
> goto when it adds the offset of a parent window from
> another process? Shouldn't the server request
> 'get_window_parents' be used to retrieve all of the
> parent windows from other processes? Or can there only
> be one parent from another process?

The get_windows_offset request will take all the parents into account
in a single call. This is to avoid having to do a separate server call
for each parent that belong to another process.