Re: [PATCH 2/4] ucrtbase: Add __std_type_info_name implementation

[Sebastian Lackner]

On 04.08.2016 16:28, Piotr Caban wrote:
> +static void CDECL type_info_entry_free(void *ptr)
> +{
> - ptr = (char*)ptr - FIELD_OFFSET(type_info_entry, name);
> - MSVCRT_free(ptr);
>
> +}

[...]
> -
>          else
> -
>          {
> -
>              type_info_entry *entry = (type_info_entry*)(name-FIELD_OFFSET(type_info_entry, name));
> -
>              InterlockedPushEntrySList(header, &entry->entry);
> -
>          }

Its up to you of course, but why not CONTAINING_RECORD in those two cases?

[PATCH 2/4] ucrtbase: Add __std_type_info_name implementation

[Piotr Caban]

On 08/04/16 18:56, Sebastian Lackner wrote:
> Its up to you of course, but why not CONTAINING_RECORD in those two cases?

I could have used CONTAINING_RECORD. Since the patch is already 
committed I don't think it's worth changing.

Thanks,
Piotr