RE: more bracket evilness

[Medland, Bill]

> -----Original Message-----
> From: Andreas Mohr [mailto:[e-mail]]
> Sent: Friday, February 01, 2002 9:54 AM
> To: Wine Patches
> Subject: more bracket evilness
>
> Hi all,
>
> you knew that I had to do this ;-)
> - fix more evil bracket stuff in some other files
>
> (I know, it's not really problematic, just makes a lot more sense)

In what way is it not problematic?  It was wrong.
> -- 
> Andreas Mohr                        Stauferstr. 6, D-71272 
> Renningen, Germany

more bracket evilness

[Andreas Mohr]

On Fri, Feb 01, 2002 at 09:06:27AM -0800, Medland, Bill wrote:
> > -----Original Message-----
> > From: Andreas Mohr [mailto:[e-mail]]
> > Sent: Friday, February 01, 2002 9:54 AM
> > To: Wine Patches
> > Subject: more bracket evilness
> >
> > Hi all,
> >
> > you knew that I had to do this ;-)
> > - fix more evil bracket stuff in some other files
> >
> > (I know, it's not really problematic, just makes a lot more sense)
>
> In what way is it not problematic?  It was wrong.

Hmm, isn't the boolean end result the same with or without fix ?
I thought it is, but maybe I'm mistaken ??

more bracket evilness

[Uwe Bonnes]

> > > > > "Andreas" == Andreas Mohr  writes:

Andreas> Hmm, isn't the boolean end result the same with or without fix
    Andreas> ?  I thought it is, but maybe I'm mistaken ??

-	    if (!dwFlags & 4)
+	    if (!(dwFlags & 4))

The first line tells:
 if ((dwFlagss == 0 & 4)
the second
 if bit 2 of dwFlags is not set

Bye

more bracket evilness

[Andreas Mohr]

On Fri, Feb 01, 2002 at 07:04:33PM +0100, Uwe Bonnes wrote:
> > > > > > "Andreas" == Andreas Mohr  writes:
> Andreas> Hmm, isn't the boolean end result the same with or without fix
> Andreas> ?  I thought it is, but maybe I'm mistaken ??
>
> -
>    if (!dwFlags & 4)
> -
>    if (!(dwFlags & 4))
>
> The first line tells:
>  if ((dwFlagss == 0 & 4)
> the second
>  if bit 2 of dwFlags is not set

Doh !

Thanks, I must have been completely and utterly blind ;-)