Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Huw Davies]

> On 21 Nov 2016, at 21:28, Alexandre Julliard  wrote:
>
> Module: wine
> Branch: master
> Commit: 8a4508cecc4a6e46da200c85aa7d62515041f6e2
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=8a4508cecc4a6e46da200c85aa...
>
> Author: Donat Enikeev 
> Date:   Sat Nov 19 21:12:30 2016 +0300
>
> crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.
>
> Signed-off-by: Donat Enikeev 
> Signed-off-by: Alexandre Julliard
>
> dlls/crypt32/tests/chain.c | 658 ++++++++++++++++++++++++---------------------
> 1 file changed, 352 insertions(+), 306 deletions(-)
>
> Diff:   http://source.winehq.org/git/wine.git/?a=commitdiff;h=8a4508cecc4a6e46da200c...

Hi Donat,

This has caused failures on some of Francois’ XP VMs.  For example:
http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-w...

Could you take a look?

Thanks,
Huw.

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Donat Enikeev]

Hi Huw,

I will, though it would be not easy to find XP with Service Pack 1

In this context, and considering Wine is going to report itself as Windows 7, could you or someone else clarify please whether testing on XP SP1 (not the latest service pack 3) is being done for purpose?

Best,
Donnie

22.11.2016, 11:59, "Huw Davies" :
> > On 21 Nov 2016, at 21:28, Alexandre Julliard  wrote:
> >
> > Module: wine
> >  Branch: master
> >  Commit: 8a4508cecc4a6e46da200c85aa7d62515041f6e2
> >  URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a4508cecc4a6e46da200c85aa...
> >
> > Author: Donat Enikeev 
> >  Date: Sat Nov 19 21:12:30 2016 +0300
> >
> > crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.
> >
> > Signed-off-by: Donat Enikeev 
> >  Signed-off-by: Alexandre Julliard
> >
> > ---
> >
> > dlls/crypt32/tests/chain.c | 658 ++++++++++++++++++++++++---------------------
> >  1 file changed, 352 insertions(+), 306 deletions(-)
> >
> > Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8a4508cecc4a6e46da200c...
>
> Hi Donat,
>
> This has caused failures on some of Francois’ XP VMs. For example:
> http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-w...
>
> Could you take a look?
>
> Thanks,
> Huw.

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Donat Enikeev]

Hi Francois,

The question around purposes of using XP SP1 as testing platform is probably to you.

I've just confirmed that tests are working on SP3 (below), so does it make sense to upgrade the testing environment to SP3? Meanwhile I am checking whether the most recent Debian 8.x fails the tests in oppose to the nightly failures reported

Also you might probably want to consider Windows XP *Embedded* as the target testing platform. It seems much more important and sensible, as it has extended support and a lot of corporate software is still there, and *any* case when one decides to move it to Wine&Linux automatically brings level-up for all involved.

What do you think? And yes, I could put another hack for the tests if XP SP1 support is crucial

X:\winetmp>ver

Microsoft Windows XP [Version 5.1.2600]

X:\winetmp>crypt32_crosstest.exe chain
chain.c:4430: Tests skipped: ignoredBadDateNestingBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4430: Tests skipped: ignoredInvalidDateBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4430: Tests skipped: ignoredInvalidUsageBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4430: Tests skipped: ignoredInvalidUsageBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4430: Tests skipped: invalidExtensionPolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0105, not checking indexes
chain.c:4677: Tests skipped: Couldn't create chain engine
chain.c:4430: Tests skipped: ignoredInvalidDateBasePolicyCheck[0](#0002): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4027: info[0] = 102
chain.c:4027: info[1] = 102
chain.c:4027: info[2] = 10a
chain: 2678 tests executed (0 marked as todo, 0 failures), 7 skipped.

Best,
Donnie

22.11.2016, 12:32, "Donat Enikeev" :
> Hi Huw,
>
> I will, though it would be not easy to find XP with Service Pack 1
>
> In this context, and considering Wine is going to report itself as Windows 7, could you or someone else clarify please whether testing on XP SP1 (not the latest service pack 3) is being done for purpose?
>
> Best,
> Donnie
>
> 22.11.2016, 11:59, "Huw Davies" :
> > > On 21 Nov 2016, at 21:28, Alexandre Julliard  wrote:
> > >
> > > Module: wine
> > >   Branch: master
> > >   Commit: 8a4508cecc4a6e46da200c85aa7d62515041f6e2
> > >   URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a4508cecc4a6e46da200c85aa...
> > >
> > > Author: Donat Enikeev 
> > >   Date: Sat Nov 19 21:12:30 2016 +0300
> > >
> > > crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.
> > >
> > > Signed-off-by: Donat Enikeev 
> > >   Signed-off-by: Alexandre Julliard
> > >
> > > ---
> > >
> > > dlls/crypt32/tests/chain.c | 658 ++++++++++++++++++++++++---------------------
> > >   1 file changed, 352 insertions(+), 306 deletions(-)
> > >
> > > Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8a4508cecc4a6e46da200c...
> >
> > Hi Donat,
> >
> > This has caused failures on some of Francois’ XP VMs. For example:
> >  http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-w...
> >
> > Could you take a look?
> >
> > Thanks,
> >  Huw.

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Alexandre Julliard]

Donat Enikeev  writes:
> Hi Huw,
>
> I will, though it would be not easy to find XP with Service Pack 1
>
> In this context, and considering Wine is going to report itself as
> Windows 7, could you or someone else clarify please whether testing on
> XP SP1 (not the latest service pack 3) is being done for purpose?

I don't think we care about older service packs anymore. If it's easy to
fix we should do it, but otherwise, succeeding with the latest service
pack is good enough.

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Francois Gouget]

On Tue, 22 Nov 2016, Alexandre Julliard wrote:
> Donat Enikeev  writes:
> > Hi Huw,
> >
> > I will, though it would be not easy to find XP with Service Pack 1
> >
> > In this context, and considering Wine is going to report itself as
> > Windows 7, could you or someone else clarify please whether testing on
> > XP SP1 (not the latest service pack 3) is being done for purpose?
>
> I don't think we care about older service packs anymore. If it's easy to
> fix we should do it, but otherwise, succeeding with the latest service
> pack is good enough.

I have removed the pre-SP3 VMs. So what's left running is:
winxp-3sp      SP3 + IE7
winxp-3spie8   SP3 + IE8
winxp-last     SP3 + IE8 + all updates to 2014/09/09
winxp-lusr     same as winxp-last but as a "limited user"

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Francois Gouget]

On Tue, 22 Nov 2016, Huw Davies wrote:
[...]
> This has caused failures on some of Francois’ XP VMs.  For example:
> http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-w...

Another more important place where tests fail is on Debian:
https://test.winehq.org/data/0e8bb752b8c9423540086df114ee00114b24d493/linux_...

I believe Hans is planning to look into it but since this is fresh in 
your mind maybe you have ideas about it.

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Donat Enikeev]

Hi Francois,
> Another more important place where tests fail is on Debian

Yes, I saw that nightly failures, and has started downloading latest Debian ISO to confirm that the packages are outdated
> but since this is fresh in your mind maybe you have ideas about it.

I believe the distribution should be updated - there are Debians without the failures like fg-acer64-t32 (The 32-bit Wine & WineTest built and run on my 64-bit Debian Testing laptop with HD4000 graphics.)

I am not that familiar with Debian, but probably update of this package will solve the issue

https://packages.debian.org/jessie/ca-certificates

Best,
Donnie

23.11.2016, 03:09, "Francois Gouget" :
> On Tue, 22 Nov 2016, Huw Davies wrote:
> [...]
> > This has caused failures on some of Francois’ XP VMs. For example:
> >  http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-w...
>
> Another more important place where tests fail is on Debian:
> https://test.winehq.org/data/0e8bb752b8c9423540086df114ee00114b24d493/linux_...
>
> I believe Hans is planning to look into it but since this is fresh in
> your mind maybe you have ideas about it.
>
> --
> Francois Gouget  http://fgouget.free.fr/
>           The last time religion ruled, it was called the dark ages.

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Donat Enikeev]

Hi Francois,

If package upgrade doesn't solve the issue, you could just copy "/etc/ssl/certs/ca-certificates.crt" from the latest Debian and replace whatever is there on the older Debian or just put near under different name

As the very last step I could submit a patch https://testbot.winehq.org/JobDetails.pl?Key=26849

Effectively it is compromising tests allowing them to be `broken` on Linux and expecting 0x800B0109L CERT_E_UNTRUSTEDROOT , though I still think that updating root certificates is a better way to go for several reasons (not just in context of fixing tests)

Best,
Donnie

23.11.2016, 12:05, "Donat Enikeev" :
> Hi Francois,
> > Another more important place where tests fail is on Debian
>
> Yes, I saw that nightly failures, and has started downloading latest Debian ISO to confirm that the packages are outdated
> > but since this is fresh in your mind maybe you have ideas about it.
>
> I believe the distribution should be updated - there are Debians without the failures like fg-acer64-t32 (The 32-bit Wine & WineTest built and run on my 64-bit Debian Testing laptop with HD4000 graphics.)
>
> I am not that familiar with Debian, but probably update of this package will solve the issue
>
> https://packages.debian.org/jessie/ca-certificates
>
> Best,
> Donnie
>
> 23.11.2016, 03:09, "Francois Gouget" :
> > On Tue, 22 Nov 2016, Huw Davies wrote:
> >  [...]
> > > This has caused failures on some of Francois’ XP VMs. For example:
> > >   http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-w...
> >
> > Another more important place where tests fail is on Debian:
> >  https://test.winehq.org/data/0e8bb752b8c9423540086df114ee00114b24d493/linux_...
> >
> > I believe Hans is planning to look into it but since this is fresh in
> >  your mind maybe you have ideas about it.
> >
> > --
> >  Francois Gouget  http://fgouget.free.fr/
> >            The last time religion ruled, it was called the dark ages.

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Francois Gouget]

On Wed, 23 Nov 2016, Donat Enikeev wrote:
> Hi Francois,
> > Another more important place where tests fail is on Debian
>
> Yes, I saw that nightly failures, and has started downloading latest 
> Debian ISO to confirm that the packages are outdated
> > but since this is fresh in your mind maybe you have ideas about it.
>
> I believe the distribution should be updated - there are Debians 
> without the failures like fg-acer64-t32

I have upgraded cw1's ca-certificates package to the latest from Debian 
Stable, that is 20141019+deb8u1. It still seems old particularly 
compared to my laptop (fg-acer64-t32, Debian Testing) which has 
20160104. But Debian usually backports updates to Stable rather than 
upgrading to the latest upstream.

A make chain.ok succeeded so that seems encouraging. If that 
works out I will update cw2 also.

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Donat Enikeev]

Thank you, looking forward

Meanwhile, could you please clarify what distributions are on VMs with as-f25-* prefix (like as-f25-win64)? I see chain tests are failing there as well, but for google

Best,
Donnie

23.11.2016, 21:46, "Francois Gouget" :
> On Wed, 23 Nov 2016, Donat Enikeev wrote:
> > Hi Francois,
> >
> > > Another more important place where tests fail is on Debian
> >
> > Yes, I saw that nightly failures, and has started downloading latest
> >  Debian ISO to confirm that the packages are outdated
> >
> > > but since this is fresh in your mind maybe you have ideas about it.
> >
> > I believe the distribution should be updated - there are Debians
> >  without the failures like fg-acer64-t32
>
> I have upgraded cw1's ca-certificates package to the latest from Debian
> Stable, that is 20141019+deb8u1. It still seems old particularly
> compared to my laptop (fg-acer64-t32, Debian Testing) which has
> 20160104. But Debian usually backports updates to Stable rather than
> upgrading to the latest upstream.
>
> A make chain.ok succeeded so that seems encouraging. If that
> works out I will update cw2 also.
>
> --
> Francois Gouget

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Francois Gouget]

On Wed, 23 Nov 2016, Donat Enikeev wrote:
> Thank you, looking forward
>
> Meanwhile, could you please clarify what distributions are on VMs with 
> as-f25-* prefix (like as-f25-win64)? I see chain tests are failing 
> there as well, but for google

Those are not mine so I have no idea. f25 would suggest Fedora 25.

You can find the person managing the machine (likely not a VM) on the 
test result's information page:

https://test.winehq.org/data/0e8bb752b8c9423540086df114ee00114b24d493/linux_...

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Alasdair Sinclair]

On Wed, 23 Nov 2016, 19:56 Donat Enikeev,  wrote:
> Thank you, looking forward
>
> Meanwhile, could you please clarify what distributions are on VMs with
> as-f25-* prefix (like as-f25-win64)? I see chain tests are failing there as
> well, but for google
>
> Best,
> Donnie

Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Alasdair Sinclair]

Donat

Those tests are mine, run on my laptop.
It's running Fedora 25, its just running on the intel 4000 graphics,
I also run the winetest exe from winehq, which can sometimes give different
results than make test.

Regards

Alasdair

On Wed, 23 Nov 2016 at 19:56 Donat Enikeev  wrote:
> Thank you, looking forward
>
> Meanwhile, could you please clarify what distributions are on VMs with
> as-f25-* prefix (like as-f25-win64)? I see chain tests are failing there as
> well, but for google
>
> Best,
> Donnie