Re: W->A cleanup of DirectDrawEnumerateEx part 4

[Mike McCormack]

You should post one patch not four that depend upon each other.

Rule of Thumb:
* After each patch is applied, the CVS should build and work.

Mike

James Hawkins wrote:
> Changelog
>     * cleanup cross calls in DirectDrawEnumerateEx

W->A cleanup of DirectDrawEnumerateEx part 4

[Mike Hearn]

On Sun, 29 Aug 2004 02:52:12 +0900, Mike McCormack wrote:
> Rule of Thumb:
> - After each patch is applied, the CVS should build and work.

I'd just like to elaborate on this point : CVS should build and work but
the feature or whatever it is you're working on doesn't necessarily have
to be complete. That's why I posted binary relocatability in two parts,
after the first part Wine will still work just fine, but the feature isn't
complete. Only after all the parts are applied will the feature become
active.

But, it made sense to split it into two parts, as that way the changes are
easier to review.

Knowing where and how to split patches is a bit of a black art but comes
with practice. Following Mikes rule of thumb can help a lot.

thanks -mike