Hi All,
Now that vkd3d 1.10 is out, I have a request for developers.
Would it be possible to include a file of all games/applications that have fixes when they are committed. It's too hard to track unless you really doing serious work with it.
The whole concept of including the latest vk3d3d in staging was to help with testing but if people don't know what to test, they wont.
This would also, give a nice section in the ANNOUNCE as to what now works. :)
Best Regards Alistair
Hi,
Il 07/12/23 21:13, Alistair Leslie-Hughes ha scritto:
Would it be possible to include a file of all games/applications that have fixes when they are committed. It's too hard to track unless you really doing serious work with it.
It looks like a sensible request. I usually mention games which are fixed by a commit in the commit message, but it's true that having a list somewhere is easier than scanning all the commits in a new version.
Gio.
On 18/12/2023 13.13, Giovanni Mascellani wrote:
Il 07/12/23 21:13, Alistair Leslie-Hughes ha scritto:
Would it be possible to include a file of all games/applications that have fixes when they are committed. It's too hard to track unless you really doing serious work with it.
It looks like a sensible request. I usually mention games which are fixed by a commit in the commit message, but it's true that having a list somewhere is easier than scanning all the commits in a new version.
How would that work in concrete terms though? Is the idea here that someone is volunteering to keep track of this and hand the maintainer a list to include in the release notes? Or would we keep something along the lines of a ChangeLog file that individual developers should update in their MRs? Perhaps something else entirely?
Henri
Hi Henri
On 9/1/24 06:44, Henri Verbeet wrote:
On 18/12/2023 13.13, Giovanni Mascellani wrote:
Il 07/12/23 21:13, Alistair Leslie-Hughes ha scritto:
Would it be possible to include a file of all games/applications that have fixes when they are committed. It's too hard to track unless you really doing serious work with it.
It looks like a sensible request. I usually mention games which are fixed by a commit in the commit message, but it's true that having a list somewhere is easier than scanning all the commits in a new version.
How would that work in concrete terms though? Is the idea here that someone is volunteering to keep track of this and hand the maintainer a list to include in the release notes? Or would we keep something along the lines of a ChangeLog file that individual developers should update in their MRs? Perhaps something else entirely?
The Changelog idea was what I was thinking. The developer already knows what game/application they are fixing, so makes sense to be part of the MR.
Pushing the burden on to the maintainer, feels like double handling of information which means it will get lost/forgotten.
Regards Alistair
Hi,
Il 08/01/24 20:44, Henri Verbeet ha scritto:
How would that work in concrete terms though? Is the idea here that someone is volunteering to keep track of this and hand the maintainer a list to include in the release notes? Or would we keep something along the lines of a ChangeLog file that individual developers should update in their MRs? Perhaps something else entirely?
Thinking again, a more lightweight solution might be to introduce a tag that we can use in commit messages and can be easily grepped for when nearing the release. Something like:
Impacted-Application: The Incredible Machine
I'm using a generic word rather than "fixed" or "improved" because in general the impact might be negative, or the submitter might fear that. I gather that the request is about having a list of all the applications that vkd3d maintainers know or suspect it makes sense to test when nearing the release time, which is a broader concept that just applications that were fixed.
How does that sound?
Gio.
-
Alistair Leslie-Hughes -
Giovanni Mascellani -
Henri Verbeet