Testers on windows needed

[Stefan Leichter]

Hello,

i'm looking for some good souls testing the attached patch one windows.

While looking for bug 7701 i found that the function __vbaNew2 of the 
MSVBVM60.dll does not like return values from SHGetFileInfoA bigger than 
0x7fff

Can you please report at least the results of the trace statements and if any 
modified test fails for you, the console output is fine for me too.

Thanks for your help
Stefan

[Hin-Tak Leung]

--- On Tue, 28/7/09, Stefan Leichter  wrote:
> Hello,
>
> i'm looking for some good souls testing the attached patch
> one windows.
>
> While looking for bug 7701 i found that the function
> __vbaNew2 of the 
> MSVBVM60.dll does not like return values from
> SHGetFileInfoA bigger than 
> 0x7fff
>
> Can you please report at least the results of the trace
> statements and if any 
> modified test fails for you, the console output is fine for
> me too.
>
> Thanks for your help
> Stefan

If I remember correctly, MSVBVM60.dll isn't one of core wine dll's, so it would need to be installed via winetricks or copied over from windows i.e. it has to be native, no built-ins... wouldn't be the same as running your test under wine?

In a different thought, I think your question is less about whether MSVBVM60.dll like certain return values (presumably you already verified that at least one case it does not), but what versions of MSVBVM60.dll are out there, and do they behave all in the same way... i.e. you probably like people to report on the version of MSVBVM60.dll (from winedump, for example) also, rather than just test it and report success/failure?

[Stefan Leichter]

Am Tuesday 28 July 2009 18:56:46 schrieb Hin-Tak Leung:
> --- On Tue, 28/7/09, Stefan Leichter  wrote:
> > Hello,
> >
> > i'm looking for some good souls testing the attached patch
> > one windows.
> >
> > While looking for bug 7701 i found that the function
> > __vbaNew2 of the
> > MSVBVM60.dll does not like return values from
> > SHGetFileInfoA bigger than
> > 0x7fff
> >
> > Can you please report at least the results of the trace
> > statements and if any
> > modified test fails for you, the console output is fine for
> > me too.
> >
> > Thanks for your help
> > Stefan
>
> If I remember correctly, MSVBVM60.dll isn't one of core wine dll's, so it
> would need to be installed via winetricks or copied over from windows i.e.
> it has to be native, no built-ins... wouldn't be the same as running your
> test under wine?
>
> In a different thought, I think your question is less about whether
> MSVBVM60.dll like certain return values (presumably you already verified
> that at least one case it does not), but what versions of MSVBVM60.dll are
> out there, and do they behave all in the same way... i.e. you probably like
> people to report on the version of MSVBVM60.dll (from winedump, for
> example) also, rather than just test it and report success/failure?

The tests are not for the function __vbaNew2 of MSVBVM60.dll. The tests are 
for SHGetFileInfoA function in shell32.dll. The implementaion of the 
SHGetFileInfoA function in wine makes the __vbaNew2 function fail. Therefore 
the tests of the function SHGetFileInfoA were made stricter to satisfy the  
function __vbaNew2. If the modified test are succeeding on all windows 
versions, the implementaion of SHGetFileInfoA in wine can be changed to 
succeed too, and the problem is fixed.

[Nicolas Le Cam]

2009/7/28 Stefan Leichter :
> Hello,
>
> i'm looking for some good souls testing the attached patch one windows.
>
> While looking for bug 7701 i found that the function __vbaNew2 of the
> MSVBVM60.dll does not like return values from SHGetFileInfoA bigger than
> 0x7fff
>
> Can you please report at least the results of the trace statements and if any
> modified test fails for you, the console output is fine for me too.
>
> Thanks for your help
> Stefan

Hi Stefan, here are the results on my boxes.

French 2K SP4 :
shlfileop.c:192: SHGetFileInfoA('') 1
shlfileop.c:229: SHGetFileInfoA(c:\nonexistent) 1
shlfileop.c:251: SHGetFileInfoA(c:\nonexistent) 1
shlfileop.c:270: SHGetFileInfoA(C:\WINNT\system32\notepad.exe) 1
shlfileop.c:277: SHGetFileInfoA(C:\WINNT\system32\notepad.exe) 1
shlfileop.c:292: SHGetFileInfoA(test4.txt) 1
shlfileop.c:299: SHGetFileInfoA(test4.txt) 1
shlfileop.c:313: SHGetFileInfoA(c:) 1
shlfileop: 622 tests executed (0 marked as todo, 0 failures), 0 skipped.

French XP SP3 :
shlfileop.c:192: SHGetFileInfoA('') 1
shlfileop.c:229: SHGetFileInfoA(c:\nonexistent) 1
shlfileop.c:251: SHGetFileInfoA(c:\nonexistent) 1
shlfileop.c:270: SHGetFileInfoA(C:\WINDOWS\system32\notepad.exe) 1
shlfileop.c:277: SHGetFileInfoA(C:\WINDOWS\system32\notepad.exe) 1
shlfileop.c:292: SHGetFileInfoA(test4.txt) 1
shlfileop.c:299: SHGetFileInfoA(test4.txt) 1
shlfileop.c:313: SHGetFileInfoA(c:) 1
shlfileop: 622 tests executed (0 marked as todo, 0 failures), 0 skipped.

No new failures on root drive directories or network directories.