Re: WIne help - get rid of W->A calls

[Eric Pouech]

hatky wrote:
> My first patch, so a deep check is welcome
>
> Change log:
>     - Remove W->A call from WineHelpA/W
>     - This patch is dedicated to dimi that guided me

I'm afraid the patch is wrong.
the current implentation of WinHelp, which sends data from any app to 
the program winhelp, requires that the data block passed between those 
two apps encodes strings in ASCII, not unicode.
Your patch modifies the sender so that it encodes in Unicode, but the 
receiver is left untouched.

I'd suggest anyway that we remain as close as possible as Windows do.
- we don't completly handle this protocol as Windows do (Windows send a 
WM_HELP - registered - message, we only use a WM_COPYDATA), but the 
format of the message (parameter block) is quite the same (we just add 
some extra fields to ensure that we don't mess with a spurious 
WM_COPYDATA message in winhelp).
- as Windows encode strings in this message block in ASCII, I'd suggest 
keeping the encoding of strings inside the message as ASCII.

A+

WIne help - get rid of W->A calls

[hatky]

> ASCII, I'd suggest 
> keeping the encoding of strings inside the message
> as ASCII.

Do you mean the conver of lpHelpFile in WinHelpA
before it calls WinHelpW?

p.s. sorry I didn't find time for this doing the week
Hatky.

__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

WIne help - get rid of W->A calls

[Dimitrie O. Paun]

On Fri, 12 Sep 2003, hatky wrote:
> Do you mean the conver of lpHelpFile in WinHelpA
> before it calls WinHelpW?

It means that somehow you picked another tricky
example to work on :) WinHelp is a very special
API in that it does some fucky/ugly stuff to
pass data between apps.

I'd do another one instead...