[PATCH 2/2 v4] winmm: Test mmioOpen with long file name

[Andrew Eikum]

Signed-off-by: Andrew Eikum 
---
 dlls/winmm/tests/mmio.c | 53 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/dlls/winmm/tests/mmio.c b/dlls/winmm/tests/mmio.c
index 5501c319c57..e3984fbaf3a 100644
--- a/dlls/winmm/tests/mmio.c
+++ b/dlls/winmm/tests/mmio.c
@@ -471,6 +471,58 @@ static void test_mmioOpen(char *fname)
     mmioClose(hmmio, 0);
 }

+static void test_mmioOpen_create(void)
+{
+    HMMIO hmmio;
+    HANDLE handle;
+    WCHAR cwd[MAX_PATH], temp_dir[MAX_PATH];
+    /* According to docs, filename must be no more than 128 bytes, but it will
+     * actually allow longer than that. */
+    WCHAR filename[] = L"very_long_filename_"
+        L"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
+        L"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
+        L"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx";
+
+    GetCurrentDirectoryW(ARRAY_SIZE(cwd), cwd);
+    GetTempPathW(ARRAY_SIZE(temp_dir), temp_dir);
+    SetCurrentDirectoryW(temp_dir);
+
+    DeleteFileW(filename);
+
+    /* open with MMIO_DENYNONE */
+    hmmio = mmioOpenW(filename, NULL, MMIO_CREATE | MMIO_WRITE | MMIO_DENYNONE);
+    ok(hmmio != NULL, "mmioOpen failed\n");
+
+    /* MMIO_DENYNONE lets us open it here, too */
+    handle = CreateFileW(filename, GENERIC_READ,
+            FILE_SHARE_WRITE | FILE_SHARE_READ | FILE_SHARE_DELETE, NULL,
+            OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
+    ok(handle != INVALID_HANDLE_VALUE, "Couldn't open non-exclusive file\n");
+    CloseHandle(handle);
+
+    mmioClose(hmmio, 0);
+
+    DeleteFileW(filename);
+
+    /* open with MMIO_EXCLUSIVE */
+    hmmio = mmioOpenW(filename, NULL, MMIO_CREATE | MMIO_WRITE | MMIO_EXCLUSIVE);
+    ok(hmmio != NULL, "mmioOpen failed\n");
+
+    /* should fail due to MMIO_EXCLUSIVE */
+    handle = CreateFileW(filename, GENERIC_READ,
+            FILE_SHARE_WRITE | FILE_SHARE_READ | FILE_SHARE_DELETE, NULL,
+            OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
+    ok(handle == INVALID_HANDLE_VALUE, "Opening exclusive file should have failed\n");
+    if(handle != INVALID_HANDLE_VALUE)
+        CloseHandle(handle);
+
+    mmioClose(hmmio, 0);
+
+    DeleteFileW(filename);
+
+    SetCurrentDirectoryW(cwd);
+}
+
 static void test_mmioSetBuffer(char *fname)
 {
     char buf[256];
@@ -1016,6 +1068,7 @@ START_TEST(mmio)
     test_mmioDescend(fname);
     test_mmioOpen(NULL);
     test_mmioOpen(fname);
+    test_mmioOpen_create();
     test_mmioSetBuffer(NULL);
     test_mmioSetBuffer(fname);
     test_mmioOpen_fourcc();

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=69033

Your paranoid android.

=== w1064v1809_ja (32 bit report) ===

Report validation errors:
The report seems to have been truncated