Re: [4/8] WineD3D: Depth stencil fixes

[H. Verbeet]

On 13/11/2007, Stefan Dösinger  wrote:
> static void depth_copy(IWineD3DDevice *iface) {
>      IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface;
> - IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl *)This->depthStencilBuffer;
> -
>
> IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl *)This->auto_depth_stencil_buffer;
>
> /* Only copy the depth buffer if there is one. */

I think this one should be changed to use stencilBufferTarget instead,
although not in this patch.

[4/8] WineD3D: Depth stencil fixes

[Stefan Dösinger]

Am Mittwoch, 14. November 2007 09:46:02 schrieb H. Verbeet:
> On 13/11/2007, Stefan Dösinger  wrote:
> > static void depth_copy(IWineD3DDevice *iface) {
> >      IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface;
> > - IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl
> >
> > *)This->depthStencilBuffer; +    IWineD3DSurfaceImpl *depth_stencil =
> > (IWineD3DSurfaceImpl *)This->auto_depth_stencil_buffer;
> >  /* Only copy the depth buffer if there is one. */
>
> I think this one should be changed to use stencilBufferTarget instead,
> although not in this patch.

I thought about that too, but does the depth copy ever apply to other stencil 
buffers than the implicit one?

[4/8] WineD3D: Depth stencil fixes

[H. Verbeet]

On 14/11/2007, Stefan Dösinger  wrote:
> Am Mittwoch, 14. November 2007 09:46:02 schrieb H. Verbeet:
> > On 13/11/2007, Stefan Dösinger  wrote:
> > > static void depth_copy(IWineD3DDevice *iface) {
> > >      IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface;
> > > - IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl
> > >
> > > *)This->depthStencilBuffer; +    IWineD3DSurfaceImpl *depth_stencil =
> > > (IWineD3DSurfaceImpl *)This->auto_depth_stencil_buffer;
> > >  /* Only copy the depth buffer if there is one. */
> >
> > I think this one should be changed to use stencilBufferTarget instead,
> > although not in this patch.
>
> I thought about that too, but does the depth copy ever apply to other stencil
> buffers than the implicit one?

It applies to whatever depth stencil is active at the time you switch
between rendering onscreen/offscreen.