Regression in comctl32

[Pavel Troller]

Hi!
  I just found a regression in comctl32 and bisected it successfully.
  The following commit

369749dcb2ba12ce8481503543afd18ad99805d1 is first bad commit
commit 369749dcb2ba12ce8481503543afd18ad99805d1
Author: Dmitry Timoshkov 
Date:   Mon Feb 12 16:47:56 2007 +0800

comctl32: Make ImageList_Read and ImageList_Write compatible with each other, simplify the code.

:040000 040000 7a8b282d58c6a6111ad0995eb8d47cbfbc8cadb0 afca21972669e3d013eef8de59556675a0bc798b M      dlls

causes that IDA Pro shows black squares instead of its toolbar icons.

With regards, Pavel Troller

[Paul Romanyszyn]

Pavel Troller wrote:
> Hi!
>   I just found a regression in comctl32 and bisected it successfully.
>   The following commit
>
> 369749dcb2ba12ce8481503543afd18ad99805d1 is first bad commit
> commit 369749dcb2ba12ce8481503543afd18ad99805d1
> Author: Dmitry Timoshkov 
> Date:   Mon Feb 12 16:47:56 2007 +0800
> comctl32: Make ImageList_Read and ImageList_Write compatible with each other, simplify the code.
>
> :040000 040000 7a8b282d58c6a6111ad0995eb8d47cbfbc8cadb0 afca21972669e3d013eef8de59556675a0bc798b M      dlls
>
> causes that IDA Pro shows black squares instead of its toolbar icons.
>     With regards, Pavel Troller

See bug 7405 for 2 additional programs.
> http://bugs.winehq.org/show_bug.cgi?id=7405

Paul R.

[Dmitry Timoshkov]

"Pavel Troller"  wrote:
> I just found a regression in comctl32 and bisected it successfully.
>  The following commit
>
> 369749dcb2ba12ce8481503543afd18ad99805d1 is first bad commit
> commit 369749dcb2ba12ce8481503543afd18ad99805d1
> Author: Dmitry Timoshkov 
> Date:   Mon Feb 12 16:47:56 2007 +0800
>
> comctl32: Make ImageList_Read and ImageList_Write compatible with each other, simplify the code.
>
> :040000 040000 7a8b282d58c6a6111ad0995eb8d47cbfbc8cadb0 afca21972669e3d013eef8de59556675a0bc798b M      dlls
>
> causes that IDA Pro shows black squares instead of its toolbar icons.

The regrssion was reported already and the the bug #7405 tracks
its status. I'm working on it.