Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626
Your paranoid android.
=== WINEBUILD (build) === Make failed
(Marvin) wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626
Your paranoid android.
=== WINEBUILD (build) === Make failed
Looks like you did not test the build before running it against the testbot (I've been guilty of this as well.)
Rebase your code against the most current git and then resubmit.
James McKenzie
On Sat, Aug 21, 2010 at 07:50:50PM -0700, James McKenzie wrote:
Looks like you did not test the build before running it against the testbot (I've been guilty of this as well.)
actually i did test it and it worked for some reason, must be magic :) in any case, after rebasing it doesn't -- and the reason seems to be that the build system assumes that each .c file under tests/ actually contains a test. is there a way around that (besides the obvious-but-ugly empty test in the common file)?
Anton Khirnov
Anton Khirnov wrote:
On Sat, Aug 21, 2010 at 07:50:50PM -0700, James McKenzie wrote:
Looks like you did not test the build before running it against the testbot (I've been guilty of this as well.)
actually i did test it and it worked for some reason, must be magic :) in any case, after rebasing it doesn't -- and the reason seems to be that the build system assumes that each .c file under tests/ actually contains a test. is there a way around that (besides the obvious-but-ugly empty test in the common file)?
One hint is if you are introducing a new function that exists in MSDN, look for an existing test case. If there is none, one will be required before Wine implementation code will be accepted. If the test exists in a file, then the implementing code should go in the corresponding .c file in the base dll directory from what I've read here over the years.
If you are introducing a new function class, then it may be best to put the tests and code into new files. Empty test case files are frowned upon unless there really is no way to successfully test what you are trying to implement, but that is extremely rare.
It is best to ask in the Wine Development list as to the most appropriate manner of implementation. The folks in the list are much more knowledgeable about this, I'm just giving suggestions.
James McKenzie
-
Anton Khirnov -
James McKenzie -
testbot＠testbot.winehq.org