Re: Patches for Hebrew and Arabic - wine-devel

21 Jun 2010

On Mon, Jun 21, 2010 at 4:00 PM, Yaron Shahrabani sh.yaron@gmail.com wrote:
...
Yaron Shahrabani
There's a few problems...
A) Please send one patch per email.
B) The patches are incorrect:
0002-Arabic-Patch.patch:
---
 programs/notepad/Makefile.in |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/programs/notepad/Makefile.in b/programs/notepad/Makefile.in
index 6b1fcdd..a0598e7 100644
--- a/programs/notepad/Makefile.in
+++ b/programs/notepad/Makefile.in
@@ -24,7 +24,6 @@ RC_SRCS = \
    Es.rc \
    Fi.rc \
    Fr.rc \
-	He.rc
    Hu.rc \
    It.rc \
    Ja.rc \
-- 
1.7.0.4

You're removing the Hebrew rc file, but nothing else.

0003-Hebrew-Patch.patch:
---
 programs/notepad/Makefile.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/programs/notepad/Makefile.in b/programs/notepad/Makefile.in
index a0598e7..372390e 100644
--- a/programs/notepad/Makefile.in
+++ b/programs/notepad/Makefile.in
@@ -14,7 +14,6 @@ C_SRCS = \
    main.c

 RC_SRCS = \
-	Ar.rc \
    Bg.rc \
    Cs.rc \
    Da.rc \
@@ -24,6 +23,7 @@ RC_SRCS = \
    Es.rc \
    Fi.rc \
    Fr.rc \
+	He.rc \
    Hu.rc \
    It.rc \
    Ja.rc \
-- 
1.7.0.4

You're adding Hebrew back and removing Arabic. Neither patch actually
adds a translation. You probably forgot to use 'git add' to tell git
to add the file in your commit.

You should also use a more helpful commit message. For example:
notepad: add Hebrew translation

Thanks for helping Wine!
-- 
-Austin


    