Dmitry Timoshkov dmitry@baikal.ru writes:
Changelog: Dmitry Timoshkov dmitry@codeweavers.com Merge the MDI and common window creation code. Change a way MDI children are managed in MDIClient. Add support for MDICREATESTRUCT A<->W conversions. Add support for WM_MDIREFRESHMENU.
The critical section thing worries me, especially since you are doing things that may require sending messages in there. I think you should use the normal USER lock when locking is really necessary; note that anything that is only accessed from the window procedure doesn't need locking at all.
On Fri, 16 Jan 2004 15:19:43 -0800, Alexandre Julliard wrote:
The critical section thing worries me, especially since you are doing things that may require sending messages in there. I think you should use the normal USER lock when locking is really necessary; note that anything that is only accessed from the window procedure doesn't need locking at all.
One thing I didn't understanding looking at the DC code was the USER lock. Why does USER not use CRITICAL_SECTIONs like everywhere else, instead of these syslevel things? Are there MSDN docs on this or is it a purely internal thing?
Mike Hearn mike@theoretic.com writes:
One thing I didn't understanding looking at the DC code was the USER lock. Why does USER not use CRITICAL_SECTIONs like everywhere else, instead of these syslevel things? Are there MSDN docs on this or is it a purely internal thing?
It's a Windows thing but I don't think it's documented. A syslevel is basically a critical section with checks to make sure you grab the locks in the right order. It's used for long lived locks like the Win16 or USER ones.
-
Alexandre Julliard -
Mike Hearn