Hello Peter,
Peter Dons Tychsen wrote:
Fixed a problem with timer values that are smaller than the minimum time that can be assigned to the SetTimer() win32 call (approx 50ms). The patch splits up the timer into several interrupts if too long time has passed.This fixes good old OutRun, which uses timers of approx 10ms. As a bonus, this aalso fixes situations where we have fallen behind for other reasons.
your patch introduces a lot of dangling whitespace at the end of lines.
bye michael
Hi Michael.
I knew it..... We are getting close to Christmas, and then this starts happening....
Every year around this time, small elves creep down from the roof, and tamper with my computer while i am sleeping. They open all of my files and fill them with whitespaces. You should see what they did to my desktop!
I will have a chat with them and try to make sure it does not happen again!
I will resend the patch when that is done,
Thanks for the tip,
/pedro
On Thu, 2008-11-27 at 11:16 +0100, Michael Stefaniuc wrote:
Hello Peter,
Peter Dons Tychsen wrote:
Fixed a problem with timer values that are smaller than the minimum time that can be assigned to the SetTimer() win32 call (approx 50ms). The patch splits up the timer into several interrupts if too long time has passed.This fixes good old OutRun, which uses timers of approx 10ms. As a bonus, this aalso fixes situations where we have fallen behind for other reasons.
your patch introduces a lot of dangling whitespace at the end of lines.
bye michael
Hello Peter,
Peter Dons Tychsen wrote:
I knew it..... We are getting close to Christmas, and then this starts happening....
Every year around this time, small elves creep down from the roof, and tamper with my computer while i am sleeping. They open all of my files and fill them with whitespaces. You should see what they did to my desktop!
I will have a chat with them and try to make sure it does not happen again!
I will resend the patch when that is done,
Thanks for the tip,
heh, I didn't include the tip but if you want it here it is: chmod a+x .git/hooks/pre-commit Run it in your (git) Wine source directory. That will prevent your elves from doing those funny whitespace tricks again.
bye michael
On Thu, 2008-11-27 at 11:16 +0100, Michael Stefaniuc wrote:
Hello Peter,
Peter Dons Tychsen wrote:
Fixed a problem with timer values that are smaller than the minimum time that can be assigned to the SetTimer() win32 call (approx 50ms). The patch splits up the timer into several interrupts if too long time has passed.This fixes good old OutRun, which uses timers of approx 10ms. As a bonus, this aalso fixes situations where we have fallen behind for other reasons.
your patch introduces a lot of dangling whitespace at the end of lines.
Am Freitag, den 28.11.2008, 10:10 +0100 schrieb Michael Stefaniuc:
Every year around this time, small elves creep down from the roof, and tamper with my computer while i am sleeping. They open all of my files and fill them with whitespaces. You should see what they did to my desktop!
heh, I didn't include the tip but if you want it here it is: chmod a+x .git/hooks/pre-commit
Great! I didn't know about that. Can we put this somewhere in one of the Wine development hint pages?
Regards, Michael Karcher
On Fri, Nov 28, 2008 at 4:51 AM, Michael Karcher karcher@physik.fu-berlin.de wrote:
Am Freitag, den 28.11.2008, 10:10 +0100 schrieb Michael Stefaniuc:
Every year around this time, small elves creep down from the roof, and tamper with my computer while i am sleeping. They open all of my files and fill them with whitespaces. You should see what they did to my desktop!
heh, I didn't include the tip but if you want it here it is: chmod a+x .git/hooks/pre-commit
Great! I didn't know about that. Can we put this somewhere in one of the Wine development hint pages?
Regards, Michael Karcher
http://wiki.winehq.org/GitWine
Hi Michael.
Yes, normally i let the tools do the job as described. However, in this case i just blamed it on the elves, as i was tired and forgot to do it :-)
Lets hope patchmaker can stop me from forgetting this ever again..... but there is no excuse for my sloppiness.
This is probably a good time to recommend and admire the kind of work done by the Wine community. It is exactly this kind of attention to detail and quality that makes Wine and other open source projects superior. The quality of the reviews done on a daily basis is exceptional.
Thanks,
/Pedro
On Fri, 2008-11-28 at 10:10 +0100, Michael Stefaniuc wrote:
Hello Peter,
Peter Dons Tychsen wrote:
I knew it..... We are getting close to Christmas, and then this starts happening....
Every year around this time, small elves creep down from the roof, and tamper with my computer while i am sleeping. They open all of my files and fill them with whitespaces. You should see what they did to my desktop!
I will have a chat with them and try to make sure it does not happen again!
I will resend the patch when that is done,
Thanks for the tip,
heh, I didn't include the tip but if you want it here it is: chmod a+x .git/hooks/pre-commit Run it in your (git) Wine source directory. That will prevent your elves from doing those funny whitespace tricks again.
bye michael
On Thu, 2008-11-27 at 11:16 +0100, Michael Stefaniuc wrote:
Hello Peter,
Peter Dons Tychsen wrote:
Fixed a problem with timer values that are smaller than the minimum time that can be assigned to the SetTimer() win32 call (approx 50ms). The patch splits up the timer into several interrupts if too long time has passed.This fixes good old OutRun, which uses timers of approx 10ms. As a bonus, this aalso fixes situations where we have fallen behind for other reasons.
your patch introduces a lot of dangling whitespace at the end of lines.
-
Austin English -
Michael Karcher -
Michael Stefaniuc -
Peter Dons Tychsen