Re: [PATCH 1/2] server: Add mechanism to retrieve the connect time of a socket (resend 2, deferred, rebased).
"Erich E. Hoover" ehoover@mines.edu writes:
Real Name: Erich Hoover
Description: This patch implements storing the connect time of a socket for retrieval with the SO_CONNECT_TIME socket option (part 2).
Changelog: server: Add mechanism to retrieve the connect time of a socket.
You should make it a generic get_info request, and return the time in standard server format.
On Tue, Apr 10, 2012 at 6:46 AM, Alexandre Julliard julliard@winehq.org wrote:
"Erich E. Hoover" ehoover@mines.edu writes: ...
Changelog: server: Add mechanism to retrieve the connect time of a socket.
You should make it a generic get_info request, and return the time in standard server format.
Maybe I'm missing something here, does this already exist somewhere in the server and I'm just not seeing it? How I originally proposed to do this was by adding a request for retrieving generic socket properties, but from your reply to that attempt it sounded like you wanted me to make a connect-specific request.
Erich Hoover ehoover@mines.edu
"Erich E. Hoover" ehoover@mines.edu writes:
On Tue, Apr 10, 2012 at 6:46 AM, Alexandre Julliard julliard@winehq.org wrote:
"Erich E. Hoover" ehoover@mines.edu writes: ...
Changelog: server: Add mechanism to retrieve the connect time of a socket.
You should make it a generic get_info request, and return the time in standard server format.
Maybe I'm missing something here, does this already exist somewhere in the server and I'm just not seeing it? How I originally proposed to do this was by adding a request for retrieving generic socket properties, but from your reply to that attempt it sounded like you wanted me to make a connect-specific request.
You had arbitrary properties stored from the client side, that's not what we want. What we want is server-side socket information with known semantics. However, there may be more than the connect time that we want to know, so a more general request is better. There are plenty of get_*_info requests already for other types of objects.
-
Alexandre Julliard -
Erich E. Hoover