[PATCH] diasymreader: Use default DllCanUnloadNow implementation.

[Mohamad Al-Jaf]

Signed-off-by: Mohamad Al-Jaf 
---
 dlls/diasymreader/diasymreader.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/diasymreader/diasymreader.spec b/dlls/diasymreader/diasymreader.spec
index 63644e07fd4..ec18371bba8 100644
--- a/dlls/diasymreader/diasymreader.spec
+++ b/dlls/diasymreader/diasymreader.spec
@@ -1,5 +1,5 @@
 @ stub CreateNGenPdbWriter
-@ stub DllCanUnloadNow
+@ stdcall -private DllCanUnloadNow()
 @ stdcall -private DllGetClassObject(ptr ptr ptr)
 @ stub DllGetClassObjectInternal
 @ stdcall -private DllRegisterServer()

[Esme Povirk (she/they)]

Can this work correctly with ThreadingModel=Both? It seems like it'd
require proxy objects..

On Sat, Apr 2, 2022 at 11:09 PM Mohamad Al-Jaf  wrote:
> Signed-off-by: Mohamad Al-Jaf
>
> dlls/diasymreader/diasymreader.spec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/diasymreader/diasymreader.spec b/dlls/diasymreader/diasymreader.spec
> index 63644e07fd4..ec18371bba8 100644
> --- a/dlls/diasymreader/diasymreader.spec
> +++ b/dlls/diasymreader/diasymreader.spec
> @@ -1,5 +1,5 @@
>  @ stub CreateNGenPdbWriter
> -@ stub DllCanUnloadNow
> +@ stdcall -private DllCanUnloadNow()
>  @ stdcall -private DllGetClassObject(ptr ptr ptr)
>  @ stub DllGetClassObjectInternal
>  @ stdcall -private DllRegisterServer()
> --
> 2.35.1

[Mohamad Al-Jaf]

On Sun, Apr 3, 2022 at 1:16 AM Esme Povirk (she/they)
 wrote:
> Can this work correctly with ThreadingModel=Both? It seems like it'd
> require proxy objects..

Hi Esme,

I have no idea, I was looking through the past commits and saw that
Alexandre added a default DllCanUnloadNow implementation. This dll was
added after that commit and is the only one that doesn't have a
DllCanUnloadNow implementation. I just found it odd that it has
neither a private implementation nor uses the default one. Taking into
account what you said, it seems like it's incorrect so please ignore
this patch.
--
Kind regards,
Mohamad

[Zebediah Figura]

On 4/3/22 00:16, Esme Povirk (she/they) wrote:
> Can this work correctly with ThreadingModel=Both? It seems like it'd
> require proxy objects..

The default DllCanUnloadNow() always prevents the DLL from being 
unloaded. Why would that be a problem with proxies?

[Esme Povirk (she/they)]

I assumed the default would do something. Should be fine then.

On Sun, Apr 3, 2022 at 10:41 AM Zebediah Figura  wrote:
> On 4/3/22 00:16, Esme Povirk (she/they) wrote:
> > Can this work correctly with ThreadingModel=Both? It seems like it'd
> > require proxy objects..
>
> The default DllCanUnloadNow() always prevents the DLL from being
> unloaded. Why would that be a problem with proxies?

[Mohamad Al-Jaf]

On Sun, Apr 3, 2022 at 11:55 AM Esme Povirk (she/they)
 wrote:
> I assumed the default would do something. Should be fine then.
>
> On Sun, Apr 3, 2022 at 10:41 AM Zebediah Figura  wrote:
> > On 4/3/22 00:16, Esme Povirk (she/they) wrote:
> > > Can this work correctly with ThreadingModel=Both? It seems like it'd
> > > require proxy objects..
> >
> > The default DllCanUnloadNow() always prevents the DLL from being
> > unloaded. Why would that be a problem with proxies?

In this case, please don't ignore this patch. :)

This might need a sign-off to get committed.
--
Kind regards,
Mohamad