First Patch - Request for Help

[Andrew Talbot]

I submitted my first patch yesterday (a janitorial patch to fix a missing 
declaration), but it looks like it didn't make the grade. I would be grateful 
for some seasoned advice on how to bring it up to the standard, please.

ChangeLog: loader.c: Add missing declaration

diff -urN a/include/wine/debug.h b/include/wine/debug.h
--- a/include/wine/debug.h      2006-05-16 20:37:38.000000000 +0100
+++ b/include/wine/debug.h      2006-05-16 21:08:26.000000000 +0100
@@ -148,6 +148,8 @@
                      const char *function, const char *format, va_list 
args );
 };
 
+extern void debug_init(void);
+
 extern unsigned char __wine_dbg_get_channel_flags( struct 
__wine_debug_channel *channel );
 extern int __wine_dbg_set_channel_flags( struct __wine_debug_channel 
*channel,
                                          unsigned char set, unsigned char 
clear );
diff -urN a/libs/wine/loader.c b/libs/wine/loader.c
--- a/libs/wine/loader.c        2006-05-16 20:37:42.000000000 +0100
+++ b/libs/wine/loader.c        2006-05-16 20:50:19.000000000 +0100
@@ -39,6 +39,7 @@
 #define NONAMELESSSTRUCT
 #include "windef.h"
 #include "winbase.h"
+#include "wine/debug.h"
 #include "wine/library.h"
 
 #ifdef __APPLE__

Thanks,

-- Andy.

[Alexandre Julliard]

Andrew Talbot  writes:
> I submitted my first patch yesterday (a janitorial patch to fix a missing 
> declaration), but it looks like it didn't make the grade. I would be grateful 
> for some seasoned advice on how to bring it up to the standard, please.

debug_init() is an internal function and there's no reason to add it
to the header file.

[Eric Pouech]

Andrew Talbot wrote:
> I submitted my first patch yesterday (a janitorial patch to fix a missing 
> declaration), but it looks like it didn't make the grade. I would be grateful 
> for some seasoned advice on how to bring it up to the standard, please.

Andrew,

I think (from the other emails you sent me) you should do the patches in 
this order:
- const string handling
- function prototypes which are intented to be (void) and declared as 
(). Beware, that a few of them should be kept as () and shouldn't be 
changed into (void)
- missing prototypes for some functions. This one is trickier, 
especially for internal/hidden prototypes, for which we don't want to 
publish them (debug_init() being one of them)

A+