Re: comctl32: move up-down msg seq tests into new 'msg' test

[James Hawkins]

On 2/13/07, Felix Nawothnig  wrote:
> Figured you might want a test for my listview patch - so first this.
> Didn't really change anything, still passed on XP SP2.
>
> dlls/comctl32/tests/Makefile.in |    1 +
>   dlls/comctl32/tests/msg.c       |  523
> +++++++++++++++++++++++++++++++++++++++
>   dlls/comctl32/tests/updown.c    |  435 +--------------------------------
>   3 files changed, 532 insertions(+), 427 deletions(-)

This is not what needs to happen.  The generic message sequence
testing code needs to be factored into msg.c, but the specific tests
need to stay in each control's test file.

comctl32: move up-down msg seq tests into new 'msg' test

[Felix Nawothnig]

James Hawkins wrote:
> This is not what needs to happen.  The generic message sequence
> testing code needs to be factored into msg.c, but the specific tests
> need to stay in each control's test file.

Guessed so... How about putting it into include/wine/test.h to share the 
code with user32/msg? Wouldn't help object size but I don't think a 
shared lib would be worth it...

Felix

comctl32: move up-down msg seq tests into new 'msg' test

[James Hawkins]

On 2/13/07, Felix Nawothnig  wrote:
> James Hawkins wrote:
> > This is not what needs to happen.  The generic message sequence
> > testing code needs to be factored into msg.c, but the specific tests
> > need to stay in each control's test file.
>
> Guessed so... How about putting it into include/wine/test.h to share the
> code with user32/msg? Wouldn't help object size but I don't think a
> shared lib would be worth it...

No, comctl32's message sequence testing code is different than
user32's, and will be even more different when I add in WM_NOTIFY
testing support.

comctl32: move up-down msg seq tests into new 'msg' test

[Lei Zhang]

On 2/13/07, James Hawkins  wrote:
> On 2/13/07, Felix Nawothnig  wrote:
> > James Hawkins wrote:
> > > This is not what needs to happen.  The generic message sequence
> > > testing code needs to be factored into msg.c, but the specific tests
> > > need to stay in each control's test file.
> >
> > Guessed so... How about putting it into include/wine/test.h to share the
> > code with user32/msg? Wouldn't help object size but I don't think a
> > shared lib would be worth it...
>
> No, comctl32's message sequence testing code is different than
> user32's, and will be even more different when I add in WM_NOTIFY
> testing support.
>
> --
> James Hawkins

I sent a couple of new patches for this:

http://www.winehq.org/pipermail/wine-patches/2007-February/035992.html
http://www.winehq.org/pipermail/wine-patches/2007-February/035993.html

- Lei