This is related to the previous patch, with a difference: this debug channel isn't actually used at all (no invocations of TRACE), so simply remove it.
Signed-off-by: Gerald Pfeifer gerald@pfeifer.com --- dlls/wldap32/ber.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/dlls/wldap32/ber.c b/dlls/wldap32/ber.c index c2c6f26949..c6ef6679a3 100644 --- a/dlls/wldap32/ber.c +++ b/dlls/wldap32/ber.c @@ -26,8 +26,6 @@ #include "winldap.h" #include "wine/debug.h"
-WINE_DEFAULT_DEBUG_CHANNEL(wldap32); - #ifndef LBER_ERROR # define LBER_ERROR (~0U) #endif
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64638
Your paranoid android.
=== debian10 (build log) ===
../../../wine/include/wine/debug.h:484:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:484:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? Task: The win32 build failed
=== debian10 (build log) ===
../../../wine/include/wine/debug.h:484:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:484:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? Task: The wow64 build failed
It is used. TRACE() is not the only way to print debug output.
On Thu, 6 Feb 2020, Nikolay Sivov wrote:
It is used. TRACE() is not the only way to print debug output.
You're right, thank you!
(I had a feeling it might be a good idea to separate that one out from the general patchset. ;-)
Gerald
-
Gerald Pfeifer -
Marvin -
Nikolay Sivov