Re: [PATCH 1/6] d3drm: Introduce d3drm_texture_destroy helper (resend).

[Henri Verbeet]

On 8 May 2016 at 12:31, Aaryaman Vasishta  wrote:
> @@ -44,6 +44,11 @@ static inline struct d3drm_texture *impl_from_IDirect3DRMTexture3(IDirect3DRMTex
>      return CONTAINING_RECORD(iface, struct d3drm_texture, IDirect3DRMTexture3_iface);
>  }
>
> +void d3drm_texture_destroy(struct d3drm_texture *texture)

You're not using this outside of texture.c.
> @@ -724,7 +729,7 @@ static ULONG WINAPI d3drm_texture3_Release(IDirect3DRMTexture3 *iface)
>      if (!refcount)
>      {
>          d3drm_object_cleanup((IDirect3DRMObject*)iface, &texture->obj);
> -
>    HeapFree(GetProcessHeap(), 0, texture);
> -
>    d3drm_texture_destroy(texture);
> }

The d3drm_object_cleanup() call should be part of d3drm_texture_destroy().