Wine staging update.

[Alistair Leslie-Hughes]

Hi Everyone,

Big thanks for Sebastian and Michael for all the work they have done over
the years to make wine-staging such a success.

The new repository is at
https://github.com/wine-staging/wine-staging

I've taken the challenge of maintaining wine-staging with the help of 
Thomas Crider
Zebediah Figura

We are in the middle of rebasing all the patches, which is a considerable task.
After two and a half months of nothing being done, there are huge amount of
conflicts. People who have never done this, please understand it is time consuming
process.  We are about 90% of our way through them.
(Advise on how to speed up this process are welcome.)

I am working on getting access to the build infrastructure to make wine-staging
packages but everything takes time.

In the short term our goals are
1. Rebase to a state that it compiles
2. Rework any patch to restore functionally.
3. Make an initial release.

Longer term Goals
1. Reduce the amount of patches in staging (Currently sitting just over 1100)
2. Improve links between a patch and application/bug report.

Once the initial release, we'll start accepting new patches.

Thanks everyone for the support and encouragement for this project to succeed.

Best Regards
  Alistair Leslie-Hughes

[Dmitry Timoshkov]

Alistair Leslie-Hughes  wrote:
> We are in the middle of rebasing all the patches, which is a considerable task.
> After two and a half months of nothing being done, there are huge amount of
> conflicts. People who have never done this, please understand it is time consuming
> process.  We are about 90% of our way through them.
> (Advise on how to speed up this process are welcome.)

Thanks for updating the staged patches, that's a real challege.
While at the moment all the patches apply cleanly there are a couple
of problems I spotted so far:
1. compiled wine-staging is not able to start up:
wine client error:0: version mismatch 549/544.
Your wine binary was not upgraded correctly,
or you have an older one somewhere in your PATH.
Or maybe the wrong wineserver is still running?
(there is no wineserver instances running and various other local wine branches
do work as expected).
2. what is the reason of removing the patch with the tests as part of
https://github.com/wine-staging/wine-staging/commit/950a11ae1deb75955cd9ee38...

Thanks again.

[Alistair Leslie-Hughes]

Hi Dmitry,

Thanks for you feedback.
> > Thanks for updating the staged patches, that's a real challege.
>
> While at the moment all the patches apply cleanly there are a couple
> of problems I spotted so far:
> - compiled wine-staging is not able to start up:
>
> wine client error:0: version mismatch 549/544.
> Your wine binary was not upgraded correctly,
> or you have an older one somewhere in your PATH.
> Or maybe the wrong wineserver is still running?
> (there is no wineserver instances running and various other local wine branches
> do work as expected).

Thanks,  Ill look into this shortly.  It hopefully will be simple to correct.
> - what is the reason of removing the patch with the tests as part of

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com...

This for some reason, cause linker errors of duplicate functions, So I though it was already merged.
I'll restore the tests in my next push.

Thanks again
Alistair.

[Dmitry Timoshkov]

Alistair Leslie-Hughes  wrote:
> > > Thanks for updating the staged patches, that's a real challege.
> >
> > While at the moment all the patches apply cleanly there are a couple
> > of problems I spotted so far:
> > - compiled wine-staging is not able to start up:
> >
> > wine client error:0: version mismatch 549/544.
> > Your wine binary was not upgraded correctly,
> > or you have an older one somewhere in your PATH.
> > Or maybe the wrong wineserver is still running?
> > (there is no wineserver instances running and various other local wine branches
> > do work as expected).
>
> Thanks,  Ill look into this shortly.  It hopefully will be simple to correct.
> > - what is the reason of removing the patch with the tests as part of
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com...
>
> This for some reason, cause linker errors of duplicate functions, So I though it was already merged.
> I'll restore the tests in my next push.

You could always ask me for help with rebasing my own patches,
especially the ones that are not supposed to be upstreamed.

Thanks again for your work!

[m.clasen]

Confirming that error.

All patches apply and it compiles but the wine executable is still at 3.2

Nontheless, you people totally rock, thanks you all for your work !!!

Am 22.02.2018 um 09:12 schrieb Dmitry Timoshkov:
> Alistair Leslie-Hughes  wrote:
> > > > Thanks for updating the staged patches, that's a real challege.
> > >
> > > While at the moment all the patches apply cleanly there are a couple
> > > of problems I spotted so far:
> > > - compiled wine-staging is not able to start up:
> > >
> > > wine client error:0: version mismatch 549/544.
> > > Your wine binary was not upgraded correctly,
> > > or you have an older one somewhere in your PATH.
> > > Or maybe the wrong wineserver is still running?
> > > (there is no wineserver instances running and various other local wine branches
> > > do work as expected).
> >
> > Thanks,  Ill look into this shortly.  It hopefully will be simple to correct.
> > > - what is the reason of removing the patch with the tests as part of
> >
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com...
> >
> > This for some reason, cause linker errors of duplicate functions, So I though it was already merged.
> > I'll restore the tests in my next push.
>
> You could always ask me for help with rebasing my own patches,
> especially the ones that are not supposed to be upstreamed.
>
> Thanks again for your work!

[Alistair Leslie-Hughes]

Hi Dmitry,
> You could always ask me for help with rebasing my own patches,
> especially the ones that are not supposed to be upstreamed.

Thanks for the offer, I'll take you up on that in future.
Can you give me a list of patches of yours that you aren't expecting to be upstreamed?

Thanks
 Alistair.

[Dmitry Timoshkov]

Alistair Leslie-Hughes  wrote:
> > You could always ask me for help with rebasing my own patches,
> > especially the ones that are not supposed to be upstreamed.
>
> Thanks for the offer, I'll take you up on that in future.
> Can you give me a list of patches of yours that you aren't expecting to be upstreamed?

I think that we already discussed this in a private e-mail echange
some time ago. From my personal perspective nothing has really changed
since then, and recent events unfortunately confirmed that once again.
If there would be a real interest in collaboration or even accepting
the patches some people could change their way of working with external
contributors, especially when they promised that so many times already.

P.S.
Feel free to add some underscores here and there to make the text more
appealing :)

[Zebediah Figura]

On 22/02/18 00:56, Dmitry Timoshkov wrote:
> - compiled wine-staging is not able to start up:
>
> wine client error:0: version mismatch 549/544.
> Your wine binary was not upgraded correctly,
> or you have an older one somewhere in your PATH.
> Or maybe the wrong wineserver is still running?
> (there is no wineserver instances running and various other local wine branches
> do work as expected).

Sorry for the late reply, but I haven't been able to reproduce this with
latest git. Can you please check again? Thanks.

[Dmitry Timoshkov]

Zebediah Figura  wrote:
> On 22/02/18 00:56, Dmitry Timoshkov wrote:
> > - compiled wine-staging is not able to start up:
> >
> > wine client error:0: version mismatch 549/544.
> > Your wine binary was not upgraded correctly,
> > or you have an older one somewhere in your PATH.
> > Or maybe the wrong wineserver is still running?
> > (there is no wineserver instances running and various other local wine branches
> > do work as expected).
>
> Sorry for the late reply, but I haven't been able to reproduce this with
> latest git. Can you please check again? Thanks.

Thanks for looking into this. No, I can no longer reproduce this problem,
wine-staging tree compiled from up to date git works here again.

Just in case I'm attachng a rebased patch that was mistakenly removed from
https://github.com/wine-staging/wine-staging/tree/master/patches/windowscode....

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=36200

Your paranoid android.

=== build (build) ===
Patch failed to apply

[Andrew Eikum]

On Wed, Feb 21, 2018 at 10:07:17PM +0000, Alistair Leslie-Hughes wrote:
> Longer term Goals
> - Reduce the amount of patches in staging (Currently sitting just over 1100)

Thanks for taking this on Alistair, Thomas, and Zebediah.

A while back someone on IRC brought up the idea of getting patches
from staging into upstream as a project for GSOC and other similar
programs. That seemed like a really good idea to me. As you're looking
through them, you could jot good candidates for upstreaming onto an
item on the GSOC page. A small bundle of those together could become a
project.

Andrew