Re: D3D8_GetCreationParameters fix

[Andrei Barbu]

I don't personally know enough about IsBadWritePtr to write a test case.
Any suggestions? :P
I'll check out the code later on, but for now it seems to be fine.

What else could it use to validate that pointer?

Andrei

On Fri, 2004-07-09 at 15:02, Mike McCormack wrote:
> Andrei Barbu wrote:
> > I think even if a wine bug might be generating that bad pointer, which I
> > don't think it is since Chessmaster works fine after that, this is how
> > DX works, so we should implement it. If it doesn't crash on windows, why
> > should it in wine?
>
> It is rare that Windows uses IsBadWritePtr to validate arguments, so if 
> you believe it works that way, prove it by writing a test case and 
> running it on a Windows box.  Somebody is going to be suprised by the 
> results ;)
>
> Mike

D3D8_GetCreationParameters fix

[Alexandre Julliard]

Andrei Barbu  writes:
> I don't personally know enough about IsBadWritePtr to write a test case.
> Any suggestions? :P
> I'll check out the code later on, but for now it seems to be fine.
>
> What else could it use to validate that pointer?

The proper way is to use an exception handler, but you should only do
that once you have demonstrated that:
  1. Windows has an exception handler in that function too
  2. The app passes a bad pointer on Windows too, so it's not just a
    consequence of another Wine bug.