Am Donnerstag, 13. März 2008 14:40:07 schrieb Artur Szymiec:
Stefan Dösinger pisze:
Am Donnerstag, 13. März 2008 10:19:36 schrieb Artur Szymiec:
This is a corrected patch. The uuid is common to dx8 and dx9 since the UUID is generated inside wined3d.
Yes, that looks reasonable. Only two small issues:
+/* Fixes BUG 11897 */
That's not really needed, specifying a GUID is correct even if it wouldn't fix a bug report.
Also, please attach the patch as an extra file to the mail, if you inline it like you did in your last mails it most likely suffers from line wrapping and can't be applied
That's final version with suggested correction by Stefan Dösinger
Sorry that I didn't think of that earlier, but do you have to use memcpy? Doesn't a simple *pIdentifier->DeviceIdentifier = IID_D3DDEVICE_D3DUID; work as well?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Stefan Dösinger pisze:
Am Donnerstag, 13. März 2008 14:40:07 schrieb Artur Szymiec:
Stefan Dösinger pisze:
Am Donnerstag, 13. März 2008 10:19:36 schrieb Artur Szymiec:
This is a corrected patch. The uuid is common to dx8 and dx9 since the UUID is generated inside wined3d.
Yes, that looks reasonable. Only two small issues:
+/* Fixes BUG 11897 */
That's not really needed, specifying a GUID is correct even if it wouldn't fix a bug report.
Also, please attach the patch as an extra file to the mail, if you inline it like you did in your last mails it most likely suffers from line wrapping and can't be applied
That's final version with suggested correction by Stefan Dösinger
Sorry that I didn't think of that earlier, but do you have to use memcpy? Doesn't a simple *pIdentifier->DeviceIdentifier = IID_D3DDEVICE_D3DUID;
work
as well?
I've corrected this like Vitaliy suggested and sent again to wine-patches.
Regards Artur
- -- - -------------------------------------------------------------------------- Registered User No 397465 Linux Debian 2.6.24.2 AMD Athlon(tm) 64 X2 Dual Core 5000+ Conquer your Desktop! http://www.kde.org/trykde/ Reclaim Your Inbox! http://www.mozilla.org/products/thunderbird/ - --------------------------------------------------------------------------
-
Artur Szymiec -
Stefan Dösinger