Re: resend: [d3d] rearrange switch statement to have FIXMEs for unhalded query types

[Alexandre Julliard]

Christoph Frick  writes:
> hiho
>
> this is a resend of a patch i sent some time ago, which was not applied.

There's already a FIXME being printed, I don't think we need two of
them.

resend: [d3d] rearrange switch statement to have FIXMEs for unhalded query types

[Christoph Frick]

On Wed, Dec 07, 2005 at 12:26:17PM +0100, Alexandre Julliard wrote:
> > this is a resend of a patch i sent some time ago, which was not applied.
>
> There's already a FIXME being printed, I don't think we need two of
> them.

the fixme in the current CVS version is not executed for the unhandled
defines (hence the break before default:) imho this queries are also not
handled by wine, but they are known to wine.

resend: [d3d] rearrange switch statement to have FIXMEs for unhalded query types

[Alexandre Julliard]

Christoph Frick  writes:
> the fixme in the current CVS version is not executed for the unhandled
> defines (hence the break before default:)

There's another FIXME just after the switch that's executed in all
cases.

resend: [d3d] rearrange switch statement to have FIXMEs for unhalded query types - d3d guru help requested

[Christoph Frick]

On Wed, Dec 07, 2005 at 01:10:49PM +0100, Alexandre Julliard wrote:
> > the fixme in the current CVS version is not executed for the unhandled
> > defines (hence the break before default:)
>
> There's another FIXME just after the switch that's executed in all
> cases.

yeah right - i just checked against my cvs-tree and saw, that this is
still open. the problem here (and some d3d guru might jump in here) is
that i think, that the comment about the lieing and the last fixme is
misleading/wrong?

first of all we no longer lie (only occlusion-query is handled the rest
not). second this is no stub - it works like advertised (ppQuery==NULL
is for checking only). following now a patch that hopefully fixes the
whole thing and give reasonable messages for user/developer.