Hi,
I now understand the purpose of SERVER_START_REQ et al, but now I'm in server/protocol.def and I'm trying to add a protocol definition for load_key. load_key is implemented in server/registry.c, but is not in server/protocol.def so, if I'm correct, I can't make a call to load_key from ntdll yet. I am trying to add load_key to protocol.def, but I don't know the semantics of this file. Is there any documentation available for this topic, or does anyone have any information that could be added to the docs?
On Tue, Mar 08, 2005 at 06:38:01PM -0600, James Hawkins wrote:
Hi,
I now understand the purpose of SERVER_START_REQ et al, but now I'm in server/protocol.def and I'm trying to add a protocol definition for load_key. load_key is implemented in server/registry.c, but is not in server/protocol.def so, if I'm correct, I can't make a call to load_key from ntdll yet. I am trying to add load_key to protocol.def, but I don't know the semantics of this file. Is there any documentation available for this topic, or does anyone have any information that could be added to the docs?
I think you should be looking at dlls/advapi32/registry.c::RegLoadKeyW()
for a registry load key implementation. It is using the load_registry request.
Ciao, Marcus
On Wed, 9 Mar 2005 07:34:16 +0100, Marcus Meissner marcus@jet.franken.de wrote:
On Tue, Mar 08, 2005 at 06:38:01PM -0600, James Hawkins wrote:
Hi,
I now understand the purpose of SERVER_START_REQ et al, but now I'm in server/protocol.def and I'm trying to add a protocol definition for load_key. load_key is implemented in server/registry.c, but is not in server/protocol.def so, if I'm correct, I can't make a call to load_key from ntdll yet. I am trying to add load_key to protocol.def, but I don't know the semantics of this file. Is there any documentation available for this topic, or does anyone have any information that could be added to the docs?
I think you should be looking at dlls/advapi32/registry.c::RegLoadKeyW()
for a registry load key implementation. It is using the load_registry request.
Ciao, Marcus
I looked at RegLoadKeyW/A, but I don't know why load_registry was chosen over load_key. If the common opinion is that we use load_registry instead of load_key, I can do that (it would be easier anyway), but the plan is to implement NtLoadKey and have RegLoadKey call NtLoadKey.
There are no docs, AFAIK, but I found the file pretty self explanatory when I read it. Which bits do you find confusing? Maybe we can document only those parts.
On Wed, 09 Mar 2005 18:55:43 +0000, Mike Hearn mike@navi.cx wrote:
There are no docs, AFAIK, but I found the file pretty self explanatory when I read it. Which bits do you find confusing? Maybe we can document only those parts.
I guess it's not so much that I can't understand it when I read through the code and read the comments, but that we should document this so whoever needs to work with the server next won't have to take time to read through the necessary files to understand it. There's also a big possibility that I'm not understanding this correctly. Some things that would be nice to see in documentation are:
* server protocol design decisions (ie why we use do...while(0) loops in SERVER_START_REQ as explained by Mike H)
* api like wine_server_add_data, wine_server_call * adding a server function to protocol.def * protocol.def: @REQ, @REPLY, @END * protocol.def: VARARG...when to use it, syntax etc * why we use DECL_HANDLER and what should go in it * why there is a function and then its counterpart DECL_HANDLER
The biggest question I have right now (because I understand minimally the points listed) is why api in protocol.def have different parameters than there reg counterparts and even ntdll api:
/* Create a registry key */ @REQ(create_key) obj_handle_t parent; /* handle to the parent key */ unsigned int access; /* desired access rights */ unsigned int options; /* creation options */ time_t modif; /* last modification time */ size_t namelen; /* length of key name in bytes */ VARARG(name,unicode_str,namelen); /* key name */ VARARG(class,unicode_str); /* class name */ @REPLY obj_handle_t hkey; /* handle to the created key */ int created; /* has it been newly created? */ @END
/* create a subkey */ /* warning: the key name must be writeable (use copy_path) */ static struct key *create_key( struct key *key, WCHAR *name, WCHAR *class, int flags, time_t modif, int *created )
NTSTATUS WINAPI NtCreateKey( PHKEY retkey, ACCESS_MASK access, const OBJECT_ATTRIBUTES *attr, ULONG TitleIndex, const UNICODE_STRING *class, ULONG options, PULONG dispos )
And then you have DECL_HANDLER(create_key).
What I'm getting at is that these things are an integral part of wine, and there isn't any documentation for it. If someone would be willing to write documentation for this topic, then wine and its developers would definitely benefit.
James Hawkins wrote:
I guess it's not so much that I can't understand it when I read through the code and read the comments, but that we should document this so whoever needs to work with the server next won't have to take time to read through the necessary files to understand it.
It's not commented because the comments can become out of date and misleading. If you want to modify Wine's internals, then you'd better take the time to thoroughly read and understand the code.
Mike
-
James Hawkins -
Marcus Meissner -
Mike Hearn -
Mike McCormack