[PATCH] ieframe: WebBrowser shouldn't support COM aggregation

[Damjan Jovanovic]

COM objects should either fully support aggregation or cleanly fail.
Our ieframe's WebBrowser completely ignores it. Fail with
CLASS_E_NOAGGREGATION like Windows does instead.

Signed-off-by: Damjan Jovanovic 
---
 dlls/ieframe/tests/webbrowser.c | 3 +++
 dlls/ieframe/webbrowser.c       | 3 +++
 2 files changed, 6 insertions(+)

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=61177

Your paranoid android.

=== wxppro (32 bit report) ===

ieframe:
09dc:webbrowser: unhandled exception c0000005 at 00407981

=== w2003std (32 bit report) ===

ieframe:
01e8:webbrowser: unhandled exception c0000005 at 00407981

=== wvistau64 (32 bit report) ===

ieframe:
0284:webbrowser: unhandled exception c0000005 at 00407981

=== w2008s64 (32 bit report) ===

ieframe:
0390:webbrowser: unhandled exception c0000005 at 00407981

=== w7u (32 bit report) ===

ieframe:
0c2c:webbrowser: unhandled exception c0000005 at 00407981

=== w8 (32 bit report) ===

ieframe:
0ca0:webbrowser: unhandled exception c0000005 at 00407981

=== w8adm (32 bit report) ===

ieframe:
0cf0:webbrowser: unhandled exception c0000005 at 00407981

=== w864 (32 bit report) ===

ieframe:
0e84:webbrowser: unhandled exception c0000005 at 00407981

=== w1064v1507 (32 bit report) ===

ieframe:
0c88:webbrowser: unhandled exception c0000005 at 00407981

=== w1064v1809 (32 bit report) ===

ieframe:
195c:webbrowser: unhandled exception c0000005 at 00407981

=== w1064v1809_2scr (32 bit report) ===

ieframe:
0f24:webbrowser: unhandled exception c0000005 at 00407981

=== w1064v1809_ar (32 bit report) ===

ieframe:
1874:webbrowser: unhandled exception c0000005 at 00407981

=== w1064v1809_he (32 bit report) ===

ieframe:
0fb4:webbrowser: unhandled exception c0000005 at 00407981

=== w1064v1809_ja (32 bit report) ===

ieframe:
19bc:webbrowser: unhandled exception c0000005 at 00407981

=== w1064v1809_zh_CN (32 bit report) ===

ieframe:
1a08:webbrowser: unhandled exception c0000005 at 00407981

=== wvistau64 (64 bit report) ===

ieframe:
0910:webbrowser: unhandled exception c0000005 at 0000000000406BD0

=== w2008s64 (64 bit report) ===

ieframe:
0390:webbrowser: unhandled exception c0000005 at 0000000000406BD0

=== w864 (64 bit report) ===

ieframe:
0870:webbrowser: unhandled exception c0000005 at 0000000000406BD0

=== w1064v1507 (64 bit report) ===

ieframe:
0fe0:webbrowser: unhandled exception c0000005 at 0000000000406BD0

=== w1064v1809 (64 bit report) ===

ieframe:
1948:webbrowser: unhandled exception c0000005 at 0000000000406BD0

=== debian10 (32 bit report) ===

ieframe:
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00407950).

Report errors:
ieframe:webbrowser crashed (c0000005)

=== debian10 (32 bit French report) ===

ieframe:
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00407950).

Report errors:
ieframe:webbrowser crashed (c0000005)

=== debian10 (32 bit Japanese:Japan report) ===

ieframe:
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00407950).

Report errors:
ieframe:webbrowser crashed (c0000005)

=== debian10 (32 bit Chinese:China report) ===

ieframe:
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00407950).

Report errors:
ieframe:webbrowser crashed (c0000005)

=== debian10 (32 bit WoW report) ===

ieframe:
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00407950).

Report errors:
ieframe:webbrowser crashed (c0000005)

=== debian10 (64 bit WoW report) ===

ieframe:
ie: Timeout
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00407950).

Report errors:
ieframe:webbrowser crashed (c0000005)

[Damjan Jovanovic]

Hi

Please reject this patch, it's wrong. Windows does support WebBrowser
aggregation, when you ask for IID_IUnknown like I should have.

Damjan

On Sun, Dec 1, 2019 at 12:47 PM Marvin  wrote:
> Hi,
>
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=61177
>
> Your paranoid android.
>
> === wxppro (32 bit report) ===
>
> ieframe:
> 09dc:webbrowser: unhandled exception c0000005 at 00407981
>
> === w2003std (32 bit report) ===
>
> ieframe:
> 01e8:webbrowser: unhandled exception c0000005 at 00407981
>
> === wvistau64 (32 bit report) ===
>
> ieframe:
> 0284:webbrowser: unhandled exception c0000005 at 00407981
>
> === w2008s64 (32 bit report) ===
>
> ieframe:
> 0390:webbrowser: unhandled exception c0000005 at 00407981
>
> === w7u (32 bit report) ===
>
> ieframe:
> 0c2c:webbrowser: unhandled exception c0000005 at 00407981
>
> === w8 (32 bit report) ===
>
> ieframe:
> 0ca0:webbrowser: unhandled exception c0000005 at 00407981
>
> === w8adm (32 bit report) ===
>
> ieframe:
> 0cf0:webbrowser: unhandled exception c0000005 at 00407981
>
> === w864 (32 bit report) ===
>
> ieframe:
> 0e84:webbrowser: unhandled exception c0000005 at 00407981
>
> === w1064v1507 (32 bit report) ===
>
> ieframe:
> 0c88:webbrowser: unhandled exception c0000005 at 00407981
>
> === w1064v1809 (32 bit report) ===
>
> ieframe:
> 195c:webbrowser: unhandled exception c0000005 at 00407981
>
> === w1064v1809_2scr (32 bit report) ===
>
> ieframe:
> 0f24:webbrowser: unhandled exception c0000005 at 00407981
>
> === w1064v1809_ar (32 bit report) ===
>
> ieframe:
> 1874:webbrowser: unhandled exception c0000005 at 00407981
>
> === w1064v1809_he (32 bit report) ===
>
> ieframe:
> 0fb4:webbrowser: unhandled exception c0000005 at 00407981
>
> === w1064v1809_ja (32 bit report) ===
>
> ieframe:
> 19bc:webbrowser: unhandled exception c0000005 at 00407981
>
> === w1064v1809_zh_CN (32 bit report) ===
>
> ieframe:
> 1a08:webbrowser: unhandled exception c0000005 at 00407981
>
> === wvistau64 (64 bit report) ===
>
> ieframe:
> 0910:webbrowser: unhandled exception c0000005 at 0000000000406BD0
>
> === w2008s64 (64 bit report) ===
>
> ieframe:
> 0390:webbrowser: unhandled exception c0000005 at 0000000000406BD0
>
> === w864 (64 bit report) ===
>
> ieframe:
> 0870:webbrowser: unhandled exception c0000005 at 0000000000406BD0
>
> === w1064v1507 (64 bit report) ===
>
> ieframe:
> 0fe0:webbrowser: unhandled exception c0000005 at 0000000000406BD0
>
> === w1064v1809 (64 bit report) ===
>
> ieframe:
> 1948:webbrowser: unhandled exception c0000005 at 0000000000406BD0
>
> === debian10 (32 bit report) ===
>
> ieframe:
> Unhandled exception: page fault on read access to 0x00000000 in 32-bit
> code (0x00407950).
>
> Report errors:
> ieframe:webbrowser crashed (c0000005)
>
> === debian10 (32 bit French report) ===
>
> ieframe:
> Unhandled exception: page fault on read access to 0x00000000 in 32-bit
> code (0x00407950).
>
> Report errors:
> ieframe:webbrowser crashed (c0000005)
>
> === debian10 (32 bit Japanese:Japan report) ===
>
> ieframe:
> Unhandled exception: page fault on read access to 0x00000000 in 32-bit
> code (0x00407950).
>
> Report errors:
> ieframe:webbrowser crashed (c0000005)
>
> === debian10 (32 bit Chinese:China report) ===
>
> ieframe:
> Unhandled exception: page fault on read access to 0x00000000 in 32-bit
> code (0x00407950).
>
> Report errors:
> ieframe:webbrowser crashed (c0000005)
>
> === debian10 (32 bit WoW report) ===
>
> ieframe:
> Unhandled exception: page fault on read access to 0x00000000 in 32-bit
> code (0x00407950).
>
> Report errors:
> ieframe:webbrowser crashed (c0000005)
>
> === debian10 (64 bit WoW report) ===
>
> ieframe:
> ie: Timeout
> Unhandled exception: page fault on read access to 0x00000000 in 32-bit
> code (0x00407950).
>
> Report errors:
> ieframe:webbrowser crashed (c0000005)