Hi,
Please find attached a patch that implements enumerating remembered (aka persistent) connections from registry. Note that this leads to the removal of the null enumerator code which is no longer used.
The next patches implement the creation and the deletion of persistent connections.
As usual, this patch series got tested on ReactOS and its purpose is to reduce the diff between Wine's MPR and ReactOS' one. The initial implementation was too broken to get into Wine. This one is correct.
Cheers,
Pierre Schweitzer pierre@reactos.org writes:
if (RegQueryInfoKeyW(remembered, NULL, NULL, NULL, NULL, &size, NULL, NULL, NULL, NULL, NULL, NULL) != ERROR_SUCCESS)
{
HeapFree(GetProcessHeap(), 0, ret);
ret = NULL;
}
ret->specific.remembered.len = size + 1;
That error handling can't possibly work. Also using RegQueryInfoKeyW() to size buffers is always a bug, the registry contents can change in the meantime.