Re: [2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

[Alexandre Julliard]

Dmitry Timoshkov  writes:
> - hwnd = WIN_GetFullHandle( hwnd );
> - if (!set_active_window( hwnd, &prev, FALSE, TRUE )) return 0;
> - set_active_window( hwnd, &prev, FALSE, TRUE );
> return prev;
>
> }

It doesn't seem right to ignore all errors. This would need some more
tests.

[2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

[Dmitry Timoshkov]

Alexandre Julliard  wrote:
> > - if (!set_active_window( hwnd, &prev, FALSE, TRUE )) return 0;
> > - set_active_window( hwnd, &prev, FALSE, TRUE );
> > return prev;
> >
> > }
>
> It doesn't seem right to ignore all errors. This would need some more
> tests.

What kind of tests do you have in mind? Invalid window? Something else?

[2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

[Alexandre Julliard]

Dmitry Timoshkov  writes:
> What kind of tests do you have in mind? Invalid window? Something else?

Yes, invalid or belonging to a different thread input.