Re: [PATCH 4/7] reg: Add wchar/type conversion functions

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-11-04 21:15, schrieb Jonathan Vollebregt:
> +#define ERROR_INVALID_TYPE      20001

What does RegSetValueEx return if you pass an invalid type? The API makes this error condition possible, so there's likely a return value for it. (Yeah, I know, it's not your fault advapi32/tests has no test for this. If I understand server/registry.c correctly such a call succeeds and creates a blob with an undefined type. Still needs tests)

ERROR_INVALID_DATATYPE may be a candidate.
> +typedef struct
> +{
> - DWORD type;
> - const WCHAR *name;
>
> +} type_rel;

You can make this anonymous too.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUWU1cAAoJEN0/YqbEcdMwBWcQAID2xh321Jci/xtp6ZJMY7cV
6bzXGGBfyBiDaCzyWiUdcZrLaGmPm6ehuV655FylMEAQvY8XGOoifdF1F6rdlqok
fwGLfdwWns6EUpdINipGbBrPFn2bKdJyP3ZECY0owEYM8H76CoJDwcgCiIrIM1T1
0uejd152KmVs/4p4kg/XYvWbJqSQc4VceHs2HPW2QG+LZ7prLEK/Cwj7PVu/sIq7
KZKrDEx6UGEkvYCr24ldWcd4qTzicnzipjnbqR8rH0F3Y0ZAL2EaQqrCfSdxj14O
Yy8YIn+QQTBa732yahs9hJrVeFYhgLboVrLavTb+AtoLeq5/TnBLwB5Gl1+EqIah
HRVK9VBNE1hlIjj84+GdUx4hicNwBwUe0a/cODC6b0LwsBh9aalawWuhOAs8R38/
xt4RNHc/1VUxC3XWNz8s0NuPjIooPLu5z4rnbyl2LM99w5mteac9wqH8mhmJE1qa
INB1yBbCGv9dccSZwzRtkyw1Lpj4762uKM6Vxk01ii2lN2uP/mWN91M9o7blga3h
+6QTL+TiiUzwVMirkjX2TxLSTDZxHXkYRadKMgerN9V//ztGmie2cIara4J4kLzm
PWDpXNguQC4WrcLzAbi7zDY3UOcxvXY4XQSCOBcIAQj254ZfTH+oBgtosWt5x9km
dsLZ0QNRy5GmHGm52ine
=10ha
-----END PGP SIGNATURE-----