Re: [PATCH 1/2] user32: Add more tests for SetWindowPos.

[Alexandre Julliard]

"Lei Zhang"  writes:
> +static UINT sequence_contains(UINT msg)
> +{
> - static const struct message end_of_sequence = { 0, 0, 0, 0 };
> - const struct message *actual;
> - UINT num = 0;
> -
> - add_message(&end_of_sequence);
> - actual = sequence;
> -
> - while (actual->message)
> - {
> -
>    if (actual->message == msg) num++;
> -
>    actual++;
> - }
> - return num;
>
> +}

The fix looks good now, but you should really test the message sequences
instead of just counting a single message. We have already all the
necessary mechanisms for this.

[PATCH 1/2] user32: Add more tests for SetWindowPos.

[Lei Zhang]

On Fri, Jul 11, 2008 at 6:28 AM, Alexandre Julliard  wrote:
> The fix looks good now, but you should really test the message sequences
> instead of just counting a single message. We have already all the
> necessary mechanisms for this.
>
> --
> Alexandre Julliard
> [e-mail]

Right, I'll send a patch that tests the entire message sequence. The
problem there is that other parts of the sequence are wrong, so I
tested for the single message I cared about to show my fix actually
does something.