Steven Edwards steven_ed4153@yahoo.com writes:
We found quite a few problems using version.dll on ReactOS and Windows XP. According to Royce there was a issue regarding ANSI converion that was causing applications (Winzip) to fail to load. Also we found that Microsoft doesnt support reading of the Win16 resources from the Win32 APIs.
I don't think that's true. The MSDN doc explicitly says that 16-bit resources are supported, and they work just fine on XP here.
Also the whole file has been reformatted, making it impossible to see what changed. Please don't do that.
On March 19, 2004 8:13 pm, Alexandre Julliard wrote:
Also the whole file has been reformatted, making it impossible to see what changed. Please don't do that.
One more note: the file seems to have been edited with a tab setting of 4. Please don't redefine tab, keep it to the standard 8, otherwise it causes no end of grief.
Dimitrie O. Paun wrote:
On March 19, 2004 8:13 pm, Alexandre Julliard wrote:
Also the whole file has been reformatted, making it impossible to see what changed. Please don't do that.
One more note: the file seems to have been edited with a tab setting of 4. Please don't redefine tab, keep it to the standard 8, otherwise it causes no end of grief.
Delenda est Carthago. Eh, no I mean some kind mandatory indent would be nice. :-)
/Jakob
On Sat, 20 Mar 2004 11:10:53 +0100, Jakob Eriksson wrote:
Delenda est Carthago. Eh, no I mean some kind mandatory indent would be nice. :-)
This is what gstreamer does. They run all code through GNU indent first to get consistent code style. Though I don't know if trying to settle on one style is really worth it....
On Sun, Mar 21, 2004 at 04:47:22PM +0000, Mike Hearn wrote:
On Sat, 20 Mar 2004 11:10:53 +0100, Jakob Eriksson wrote:
Delenda est Carthago. Eh, no I mean some kind mandatory indent would be nice. :-)
This is what gstreamer does. They run all code through GNU indent first to get consistent code style. Though I don't know if trying to settle on one style is really worth it....
Alexandre already enforces some of those rules.
Ciao, Marcus
Mike Hearn wrote:
On Sat, 20 Mar 2004 11:10:53 +0100, Jakob Eriksson wrote:
Delenda est Carthago. Eh, no I mean some kind mandatory indent would be nice. :-)
This is what gstreamer does. They run all code through GNU indent first to get consistent code style. Though I don't know if trying to settle on one style is really worth it....
Good for them!
Trying?
Somebody (Alexandre...) could just do it. Or "ci" could do it only on files marked as "indent allowed" or such with a C-style comment.
Or do you mean you other people at Codeweavers have Alexandre on a leash? ;-)
regards, Jakob
-
Alexandre Julliard -
Dimitrie O. Paun -
Jakob Eriksson -
Marcus Meissner -
Mike Hearn