Re: Solution for bug 15942 - Send page size with lpr command on printing

[Austin English]

On Sun, Nov 9, 2008 at 6:48 PM, Massimo Del Fedele  wrote:
> Send page size with 'lpr' command to CUPS, so it doesn't take always the
> default one.
> Solves bug 15942.
>
> Max

+//        sprintf(psCmd,"|lpr -P'%s'",pszOutput+4);

Don't use C++ comments, use /* comment */ instead.

Also, don't comment out code. Remove it if unneeded, or if it should
be left as an example, etc., use if(0).

Solution for bug 15942 - Send page size with lpr command on printing

[Massimo Del Fedele]

Austin English ha scritto:
> On Sun, Nov 9, 2008 at 6:48 PM, Massimo Del Fedele  wrote:
> > Send page size with 'lpr' command to CUPS, so it doesn't take always the
> > default one.
> > Solves bug 15942.
> >
> > Max
>
> +//        sprintf(psCmd,"|lpr -P'%s'",pszOutput+4);
>
> Don't use C++ comments, use /* comment */ instead.
>
> Also, don't comment out code. Remove it if unneeded, or if it should
> be left as an example, etc., use if(0).

Ok, I left it there commented just to show the small change... I'll drop 
it. Shall I repost the patch ?

Max

Solution for bug 15942 - Send page size with lpr command on printing

[L. Rahyen]

On Monday November 10 2008 08:17:00 Massimo Del Fedele wrote:
> Ok, I left it there commented just to show the small change... I'll drop
> it. Shall I repost the patch ?

Yes.