couldn't you instead when the patchwatcher takes the patch it assigns it a patch # and require if there is a patch dependency? that the person put into a comment REQ_PATCH: 123456,15456, etc.. ? That way when a diff is done for the patch it would appear in the patch diff?
Then patchwatcher would make sure thats in the tree if its accepted and if that req. patch was not accepted then the new patch is automatically rejected?
Chris
On Tue, Aug 12, 2008 at 6:47 AM, celticht32@aol.com wrote:
couldn't you instead when the patchwatcher takes the patch it assigns it a patch # and require if there is a patch dependency that the person put into a comment REQ_PATCH: 123456,15456, etc.. ?
Yes, perhaps if patchwatcher catches on and becomes a central part of Wine's workflow, that would be worth it.
2008/8/12 Dan Kegel dank@kegel.com:
On Tue, Aug 12, 2008 at 6:47 AM, celticht32@aol.com wrote:
couldn't you instead when the patchwatcher takes the patch it assigns it a patch # and require if there is a patch dependency that the person put into a comment REQ_PATCH: 123456,15456, etc.. ?
Yes, perhaps if patchwatcher catches on and becomes a central part of Wine's workflow, that would be worth it.
I like the idea of patchwatcher.
I use GMail to do something similar - tag mail I send to wine-patches with a 'wine-tracking' label, as well as the 'wine-patches' label it gets from the mailing list filter I have. This allows me to see all active patches I currently have. Once Alexandre commits them, I manually remove the 'wine-tracking' label; similarly if there are comments on it that mean I need to provide a revised patch.
Where patchwatcher would be useful is to know whether Alexandre has looked at the patch yet (no more "dly" on #winehackers) and has rejected it - hopefully with comments as to why!
It should also help catch the patches that do not apply, or cause regressions in the tests, which should help Alexandre. It will also mean that patches are not lost in a flood (e.g. coming back off holiday).
So yeah, I like the idea.
- Reece
On Tue, Aug 12, 2008 at 10:29 AM, Reece Dunn msclrhd@googlemail.com wrote:
I use GMail to do something similar - tag mail I send to wine-patches with a 'wine-tracking' label, as well as the 'wine-patches' label it gets from the mailing list filter I have. This allows me to see all active patches I currently have. Once Alexandre commits them, I manually remove the 'wine-tracking' label; similarly if there are comments on it that mean I need to provide a revised patch.
Potentially patchwatcher could monitor wine-devel for replies to the patch. The other patch monitoring systems out there do something similar; see http://bundlebuggy.aaronbentley.com/ and http://patchwork.ozlabs.org/linuxppc/
Where patchwatcher would be useful is to know whether Alexandre has looked at the patch yet (no more "dly" on #winehackers) and has rejected it - hopefully with comments as to why!
Yes, but that's harder than:
It should also help catch the patches that do not apply, or cause regressions in the tests, which should help Alexandre.
which is my primary goal.
It will also mean that patches are not lost in a flood (e.g. coming back off holiday).
Perhaps, if it becomes a real workflow application, but resubmitting fresh patches is often required anyway... - Dan
-
celticht32＠aol.com -
Dan Kegel -
Reece Dunn