Re: [5/9] wined3d: Make d3d_level_from_gl_info return an enum instead of a plain int

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-07-04 00:40, schrieb Andrei Slăvoiu:
> +enum wined3d_d3d_level
> +{
> - D3D5,
> - D3D6,
> - D3D7,
> - D3D8,
> - D3D9_SM2,
> - D3D9_SM3,
> - D3D10,
> - D3D11,
>
> +};

I'd prefer enum values like D3D_LEVEL_5 etc. I think D3Dx is too short and generic.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTt9weAAoJEN0/YqbEcdMwZ7QP/RPzNly/5CRWpcwKFI2VAh6O
IquSkL2PeTlsDRJPwiywF4lXc1IqDHnrqFRHpTfI1u+eQMijtQ2iaTMBHcClLeaY
VQGg4Td2UBenMMPjVtqLsP5FAdOZEeI8cWo6dQoA/ZMakgWqz2ZJDuLq/YhSAKFU
1msCqEyGIukOyzYp5ThbQXobVwHkJYO34ORMciHpbWRu1X97fHReAZLL21zEIwVi
RRQTPBF/O4KvCLzJMpLVG0F35Ki8vIeJJPS/QU0pN2H88n//SWQBPHE9Epm3KCE0
qczqa8P9SjW7eCJ/xD59mbc89tRUjwegcNnP7ItjiRDgAnwk98jbgyZbrQfTKyLU
b7K8xezH6kmgC6+SotPcIVtvU9Ucw6kNLhJKtlhdiEHprhQcBXTp27+uMfWCS9Nx
tsjGw8VpKJ4D6jssD7nY/b/reNZ6M3qMCQYyWiGOe1hi0gerq+ouOLBDCyTbJD2n
XcifP/jj+3BuuCO8gXJwmYECutq6Ao23ziOjgKPuqKY3XLgoMwdpUo5bylmY/m4N
tIzy1JnSZubbJVIxoeCp7nC4Eeq3YRaIMP3+cqmT8ogu9KDBQuwpNLSk/gW65OIO
9Og69K7gIvkrudCo5j/Vd8ir+JxcbhA9Hw+gJdcySZwLItiTmpX/yi31/1+6TLr+
cokSG4OFKv1ZB2izKi46
=y2DP
-----END PGP SIGNATURE-----

[5/9] wined3d: Make d3d_level_from_gl_info return an enum instead of a plain int

[Henri Verbeet]

On 5 July 2014 13:06, Stefan Dösinger  wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2014-07-04 00:40, schrieb Andrei Slăvoiu:
> > +enum wined3d_d3d_level
> > +{
> > - D3D5,
> > - D3D6,
> > - D3D7,
> > - D3D8,
> > - D3D9_SM2,
> > - D3D9_SM3,
> > - D3D10,
> > - D3D11,
> >
> > +};
>
> I'd prefer enum values like D3D_LEVEL_5 etc. I think D3Dx is too short and generic.

I think we'd want that to be WINED3D_D3D_LEVEL_5, etc.